WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 8 years ago

#4517 closed enhancement (wontfix)

Bundle Sandbox theme, and also set 'sandbox' as the default template for themes without a stylesheet

Reported by: JeremyVisser Owned by:
Milestone: Priority: low
Severity: minor Version:
Component: Template Keywords:
Focuses: Cc:

Description

I propose that we bundle the Sandbox theme with WordPress.

Sandbox is a theme which is loaded with semantic CSS selectors, making it possible to write beautiful WordPress themes with only modifying CSS. In addition, it is already widgets-friendly, and is licensed under the GPL, making it perfectly compatible with WordPress in legal terms.

There is a great deal of support for the theme out on the wp-hackers list. Bundling Sandbox has come up a few times, with general support from all directions, but nothing has really happened.

In addition to bundling Sandbox, I propose, for style.css-only themes, that Sandbox is made the default template. (e.g. without having to specify /* Template: sandbox */)

The rationale for this is that Sandbox is much easier to theme with just CSS, and is much more useful than using the Kubrick template, which doesn't contain as many selectors.

Attachments (5)

4517-add-sandbox-theme.diff (236.9 KB) - added by Speedboxer 10 years ago.
Add Sandbox Theme and Add it to wp-includes/theme.php
4517-add-sandbox-0.9.5-theme.diff (237.2 KB) - added by Speedboxer 10 years ago.
Add Sandbox 0.9.5 Theme and Add it to wp-includes/theme.php
4517-bundle-sandbox-1.0.diff (220.5 KB) - added by Speedboxer 9 years ago.
Bundle Sandbox 1.0 and add it to wp-includes/theme.php as a bundled them
4517-bundle-sandbox-1.2.diff (220.6 KB) - added by kalgriffen 9 years ago.
Include Sandbox 1.2 as a bundled theme and add it to wp-includes/theme.php. Note: the screenshot.png will have to be added manually.
4517-bundle-sandbox-svn-external.diff (1.2 KB) - added by Speedboxer 9 years ago.
Bundle sandbox with svn:externals

Download all attachments as: .zip

Change History (39)

#1 @rob1n
10 years ago

Let's drop Classic then, and replace that with Sandbox.

#2 @DD32
10 years ago

Just a thought:
Maybe it would be possible to enumerate all the *.css files from a themes folder, parse them, And then display a list of "Other Styles" alongside the theme?
ie. themes/classic/ has style.css (default) and my-style.css
my-style.css would contain "Theme Name: MY Classic theme", And that'd be offered as a alternate style?

Doing it that way would mean that other styles would have to be coded correctly so as to avoid clashing with eachothers images, But it would allow a single folder for a "Theme".

the other option would be to have a subfolder "Styles" and do it that way with all the themes in the subfolder.

This could be built directly into the theme if some hooks were present for the theme display page.. Perhaps it wouldnt even need hooks and could just be displayed on the Themes Option page.

D

#3 @joefish
10 years ago

+1 for adding Sandbox, for all the reasons mentioned in the ticket. This would be a nice addition to WordPress.

-1 for removing Classic. I know I'm in the minority on this, but I think there's room for all three themes.

#4 @JeremyVisser
10 years ago

-1 for removing Classic as well. It's a nice theme. Perhaps it could be ported to Sandbox? ;)

-1 on DD32's suggestion as well. It can be done like the following:

File: wp-content/classic-reloaded/style.css

/*
    Theme Name: Classic Reloaded
    Theme Author: Jeremy Visser
    Template: classic
*/

@import url('../classic/style.css');

body {
    background-color: #000;
    color: #f00;
}

}}}

#5 follow-up: @filosofo
10 years ago

What makes Classic nice is its simplicity for those learning how to create a WordPress theme. Porting it to Sandbox would take away that advantage, as Sandbox (the last time I checked) has some complicated stylesheet switchers that can't be simply removed.

How about dumping the old Default, and instead making the default to be Sandbox's Default lookalike?

#6 in reply to: ↑ 5 @JeremyVisser
10 years ago

Replying to filosofo:

Sandbox (the last time I checked) has some complicated stylesheet switchers that can't be simply removed.

Are you referring to the Skins menu? They dumped that soon after version 0.6. It's not present in 0.9, and I presume the "way to do things" now is to use /* Template: sandbox */ which is really quite simple, as the styles simply show up as new ones under the themes menu.

#7 follow-ups: @matt
10 years ago

Let's bring in sandbox as a non-default theme and leave existing "classic" behaviour and markup.

#8 in reply to: ↑ 7 @JeremyVisser
10 years ago

Replying to matt:

Let's bring in sandbox as a non-default theme and leave existing "classic" behaviour and markup.

By that, I presume leaving /* Template: default */ as the default. I can live with that.

#9 in reply to: ↑ 7 ; follow-up: @foolswisdom
10 years ago

Replying to matt:

Let's bring in sandbox as a non-default theme and leave existing "classic" behaviour and markup.

Please keep it out of wp-content ;-)

#10 in reply to: ↑ 9 @JeremyVisser
10 years ago

Replying to foolswisdom:

Please keep it out of wp-content ;-)

Good idea.

#11 @Speedboxer
10 years ago

  • Keywords has-patch added
  • Milestone changed from 2.4 (future) to 2.3 (trunk)

Patch 4517-add-sandbox-theme.diff adds [The Sandbox Theme http://www.plaintxt.org/themes/sandbox/] to WordPress.

I think if this does go into WP, it might as well go into 2.3...

#12 follow-up: @JeremyVisser
10 years ago

  • Keywords 2nd-opinion dev-feedback removed

We've had enough feedback to show that it's definitely going in. Thanks, guys.

Matt (Speedboxer), any idea how to get Sandbox into wp-includes?

@Speedboxer
10 years ago

Add Sandbox Theme and Add it to wp-includes/theme.php

#13 in reply to: ↑ 12 @Speedboxer
10 years ago

Replying to JeremyVisser:

We've had enough feedback to show that it's definitely going in. Thanks, guys.

Matt (Speedboxer), any idea how to get Sandbox into wp-includes?

Updated Patch 4517-add-sandbox-theme.diff Adds Sandbox 0.9.4 and Adds it as a Bundled theme in wp-includes/theme.php.

#14 @scottwallick
10 years ago

I was intending to do this myself in the near future, but I'm happier to see it suggested by another. Cheers, Jeremy.

I find /* Template: sandbox */ potentially valuable, especially considering there will (hopefully) be a respectable number of great designs available for the Sandbox after SDC concludes.

#15 follow-up: @matt
10 years ago

Although I believe Sandbox is the most advanced markup I've seen on a theme, I still don't think it's enough to preclude all template editing. Just like any other theme, I think Sandbox should live in wp-content and we should expect people to edit it just like they do with kubrick or classic.

#16 @foolswisdom
10 years ago

I'll keep dreaming of a pure wp-content and custom css / overlay system ;-)

#17 follow-up: @markjaquith
10 years ago

Well, if people modify the HTML, all those hot CSS themes aren't going to work. So hopefully that will be an incentive for them to leave it alone.

#18 in reply to: ↑ 15 ; follow-up: @JeremyVisser
10 years ago

Replying to matt:

Although I believe Sandbox is the most advanced markup I've seen on a theme, I still don't think it's enough to preclude all template editing. Just like any other theme, I think Sandbox should live in wp-content and we should expect people to edit it just like they do with kubrick or classic.

...which is partly why I'd like it to be the 'default' template for themes, because, say, you could override footer.php if you wanted to adjust that, but have all the other templates get pulled from Sandbox.

#19 in reply to: ↑ 18 @JeremyVisser
10 years ago

Replying to JeremyVisser:

...which is partly why I'd like it to be the 'default' template for themes, because, say, you could override footer.php if you wanted to adjust that, but have all the other templates get pulled from Sandbox.

Oops, actually, I think it would work anyway. Disregard.

#20 in reply to: ↑ 17 @matt
10 years ago

Replying to markjaquith:

Well, if people modify the HTML, all those hot CSS themes aren't going to work. So hopefully that will be an incentive for them to leave it alone.

When I look at common modifications around doing things like Adsense, changing hardcoded text or formatting, words for comments, all of the "content" things that CSS isn't designed to touch, it rarely has an impact on the layout. In theory we could make all of the above configurable, but I think we'd be on the wrong end of 80/20 for the benefits.

#21 @sunburntkamel
10 years ago

if we can get this committed, it would be great. sandbox still needs support for 2.3 features (tags), and doing that in trac here means that standalone sandbox can still support 2.0 without a lot of conditional statements.

#22 @JeremyVisser
10 years ago

  • Keywords commit added

There has definitely been plenty of positive feedback on this. Looks like it's time to commit. Thanks, Matt (Speedboxer), for the patch!

#23 follow-up: @JeremyVisser
10 years ago

Sandbox 0.9.5 is out. Matt, could you cook us up another patch for the new version? Your current one is for 0.9.4.

@Speedboxer
10 years ago

Add Sandbox 0.9.5 Theme and Add it to wp-includes/theme.php

#24 @Speedboxer
10 years ago

Patch 4517-add-sandbox-0.9.5-theme.diff adds Sandbox 0.9.5 and adds it as a packaged theme in wp-includes/theme.php.

#25 in reply to: ↑ 23 @Speedboxer
10 years ago

Replying to JeremyVisser:

Sandbox 0.9.5 is out. Matt, could you cook us up another patch for the new version? Your current one is for 0.9.4.

No problem, I didn't notice a new version was out. Check out Patch 4517-add-sandbox-0.9.5-theme.diff. :D

#26 @rob1n
10 years ago

  • Milestone changed from 2.3 (trunk) to 2.4 (future)

@Speedboxer
9 years ago

Bundle Sandbox 1.0 and add it to wp-includes/theme.php as a bundled them

#27 @Speedboxer
9 years ago

Patch 4517-bundle-sandbox-1.0.diff adds Sandbox 1.0 as a bundled theme. It's added in wp-includes/theme.php also.

@kalgriffen
9 years ago

Include Sandbox 1.2 as a bundled theme and add it to wp-includes/theme.php. Note: the screenshot.png will have to be added manually.

#28 @ryan
9 years ago

  • Milestone changed from 2.5 to 2.6

#29 @caesarsgrunt
9 years ago

Is this going to happen? Will it get into 2.7? (I notice the milestone is now 2.9...)

@Speedboxer
9 years ago

Bundle sandbox with svn:externals

#30 @Speedboxer
9 years ago

If we are going to bundle sandbox, we should do it with svn:externals. But, apparently, diffs don't include changes to that, so this latest patch is a fail (although when I look at it in Tortoise it shows, I must've done something wrong...).

#31 @ryan
9 years ago

  • Keywords has-patch commit removed

#32 @FFEMTcJ
8 years ago

  • Milestone changed from 2.9 to Future Release

#33 @Denis-de-Bernardy
8 years ago

Close as wontfix? I mean, honestly, there are much better themes out there. :-)

#34 @ryan
8 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

We have a new ticket about creating a new default.

Note: See TracTickets for help on using tickets.