WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45185 closed defect (bug) (fixed)

Add space after colon for css consistency

Reported by: nadim0988 Owned by: afercia
Milestone: 5.1 Priority: normal
Severity: minor Version:
Component: Administration Keywords: has-patch
Focuses: coding-standards Cc:

Description


Attachments (2)

patch.diff (383 bytes) - added by nadim0988 3 years ago.
45185.diff (96.2 KB) - added by afercia 3 years ago.

Download all attachments as: .zip

Change History (10)

@nadim0988
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Menus
  • Focuses administration added

#2 @matveb
3 years ago

  • Milestone changed from Awaiting Review to 5.0.1

#3 @ocean90
3 years ago

  • Milestone changed from 5.0.1 to 5.1

#4 @afercia
3 years ago

  • Version 5.0 deleted

Looking a bit into this, there are more occurrences of properties with a colon not followed by a space. Also, there are a few other minor coding standards fixes that can be easily addressed.

@afercia
3 years ago

#5 @afercia
3 years ago

  • Component changed from Menus to Administration
  • Focuses administration removed

In 45185.diff Based on the CSS coding standards https://make.wordpress.org/core/handbook/best-practices/coding-standards/css :

  • properties should be followed by a colon and a space.
  • media queries shouldn't use spaces within parenthesis
  • the content property should use double quotes
  • indentation: fixes spaces instead of tabs and mixed spaces / tabs
  • fixes a few double space occurrences

#6 @afercia
3 years ago

Note: there's some inconsistency about the rgba() value across the admin stylesheets. However, it should go in a separate ticket, as there are a lot of occurrences to fix. Example from the coding standards: rgba(0, 0, 0, 0.5).

#7 @afercia
3 years ago

  • Owner set to afercia
  • Status changed from new to assigned

#8 @afercia
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44637:

Administration: CSS coding standards

  • properties should be followed by a colon and a space
  • media queries shouldn't use spaces within parenthesis
  • indentation should use tabs instead of spaces or mixed spaces / tabs
  • the content property should use double quotes
  • no double spaces

Props nadim0988, afercia.
Fixes #45185.

Note: See TracTickets for help on using tickets.