WordPress.org

Make WordPress Core

#45188 closed defect (bug) (invalid)

Twenty Seventeen: Classic editor block buttons are italicized

Reported by: laurelfulford Owned by: laurelfulford
Milestone: Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

In the 5.0 Beta 1, the editor buttons in the classic block are inheriting the theme styles for the i tag. This is causing them to become italicized (screenshot attached).

The culprit looks like this particular style:

.editor-block-list__block i

... which is coming from importing the theme's existing editor styles into the new editor with add_theme_support( 'editor-styles' );.

Originally report: https://github.com/WordPress/gutenberg/issues/11034 and https://core.trac.wordpress.org/ticket/45045#comment:35.

(Thanks @ahortin for the report!)

Attachments (1)

twenty-seventeen-editor-buttons.png (46.3 KB) - added by laurelfulford 12 months ago.
Classic block with Twenty Seventeen theme, with italicized buttons.

Download all attachments as: .zip

Change History (3)

@laurelfulford
12 months ago

Classic block with Twenty Seventeen theme, with italicized buttons.

#1 @laurelfulford
12 months ago

It looks like this is affecting more than one of the default theme updates (all but Twenty Thirteen), because most of the themes set styles for i tags in the editor that are overriding the button styles.

Going to do some investigation!

#2 @laurelfulford
12 months ago

  • Milestone 5.0 deleted
  • Resolution set to invalid
  • Status changed from assigned to closed

I ended submitting a PR for this in the Gutenberg repo -- given the scope of affected default themes, it seems to make more sense to fix there:

https://github.com/WordPress/gutenberg/pull/11132

I'm going to close this theme-specific report for now.

Note: See TracTickets for help on using tickets.