"Remove featured image" link should be in Red Color

[monikarao]

All delete links are appearing in Red Color except "Remove featured image" so it should be in Red color.

[monikarao]

Currently it's appearing in Blue Color

[monikarao]

Patch

[SergeyBiryukov]

Related: #37016, #35622.

[sabernhardt]

"Remove featured image" link after patch (Firefox/Windows)

[sabernhardt]

45198.1.2.diff​ correctly matches the "Remove featured image" link to the red used for the "Move to Trash" link and other destructive actions, both in the original state and when hovering the cursor over it. Those links are also the same red in all nine standard color schemes.

Tested with Firefox 88 and Windows 10

It would be nice to make that link a button instead, but that's probably outside the scope of this ticket.

[hellofromTonya]

Test Results: before and after applying the patch

[hellofromTonya]

45198.1.2.diff​ correctly fixes the reported problem with the link color in the classic editor and does not impact the block editor.

Testing Environment:

• OS: MacOS
• Browser: Chrome v90.0.4430.93 and Firefox v88.0
• Localhost: Docker and WP Local
• Plugins: Classic Editor activated
• Theme: Twenty Twenty-One

Marking for commit.

[hellofromTonya]

Replying to sabernhardt:

It would be nice to make that link a button instead, but that's probably outside the scope of this ticket.

I agree it would be better as a button instead of a link. I too think the button enhancement is out of the scope of this ticket. There may be other links in the classic editor that could be changed to a button.

[hellofromTonya]

How to test

Reproduce the issue

Before applying the patch, follow these steps to reproduce the issue:

1. Pull the latest changes from wordpress-develop repo
2. Run the build process as noted ​in the Getting Started document
3. Install and activate the Classic Editor plugin
4. Navigate to Pages > Sample Page and open the page
5. Add a feature image
6. Update to save it
7. Notice the color of the "Remove featured image" link

Test the fix

1. Apply the patch: npm run grunt patch:45198
2. Repeat the rest of the steps from above (expect for the 1st step)

[SergeyBiryukov]

In 50844:

Post Thumbnails: Display the "Remove featured image" link in the classic editor in red color.

This matches the color of the "Move to Trash" link and other similar links for destructive actions in the admin.

Props monikarao, hareesh-pillai, sabernhardt, hellofromTonya.
Fixes #45198.