WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 5 months ago

#45198 closed defect (bug) (fixed)

"Remove featured image" link should be in Red Color

Reported by: monikarao Owned by: SergeyBiryukov
Milestone: 5.8 Priority: normal
Severity: normal Version: 4.9.8
Component: Post Thumbnails Keywords: has-patch commit has-testing-info
Focuses: ui, administration Cc:

Description

All delete links are appearing in Red Color except "Remove featured image" so it should be in Red color.

Attachments (5)

screenshot-elementor.local-2018.10.26-16-45-55.png (149.8 KB) - added by monikarao 3 years ago.
Currently it's appearing in Blue Color
45198.diff (664 bytes) - added by monikarao 3 years ago.
Patch
45198.1.2.diff (671 bytes) - added by Hareesh Pillai 6 months ago.
remove-featured-image.png (204.6 KB) - added by sabernhardt 6 months ago.
"Remove featured image" link after patch (Firefox/Windows)
45198-test-before-after.png (487.9 KB) - added by hellofromTonya 5 months ago.
Test Results: before and after applying the patch

Download all attachments as: .zip

Change History (13)

@monikarao
3 years ago

Currently it's appearing in Blue Color

@monikarao
3 years ago

Patch

#1 @SergeyBiryukov
3 years ago

  • Component changed from General to Post Thumbnails
  • Focuses administration added

#3 @Hareesh Pillai
6 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 5.8

@sabernhardt
6 months ago

"Remove featured image" link after patch (Firefox/Windows)

#4 follow-up: @sabernhardt
6 months ago

45198.1.2.diff correctly matches the "Remove featured image" link to the red used for the "Move to Trash" link and other destructive actions, both in the original state and when hovering the cursor over it. Those links are also the same red in all nine standard color schemes.

Tested with Firefox 88 and Windows 10

It would be nice to make that link a button instead, but that's probably outside the scope of this ticket.

@hellofromTonya
5 months ago

Test Results: before and after applying the patch

#5 @hellofromTonya
5 months ago

  • Keywords commit added; needs-testing removed

45198.1.2.diff correctly fixes the reported problem with the link color in the classic editor and does not impact the block editor.

Testing Environment:

  • OS: MacOS
  • Browser: Chrome v90.0.4430.93 and Firefox v88.0
  • Localhost: Docker and WP Local
  • Plugins: Classic Editor activated
  • Theme: Twenty Twenty-One

Marking for commit.

#6 in reply to: ↑ 4 @hellofromTonya
5 months ago

Replying to sabernhardt:

It would be nice to make that link a button instead, but that's probably outside the scope of this ticket.

I agree it would be better as a button instead of a link. I too think the button enhancement is out of the scope of this ticket. There may be other links in the classic editor that could be changed to a button.

#7 @hellofromTonya
5 months ago

  • Keywords has-testing-info added

How to test

Reproduce the issue

Before applying the patch, follow these steps to reproduce the issue:

  1. Pull the latest changes from wordpress-develop repo
  2. Run the build process as noted in the Getting Started document
  3. Install and activate the Classic Editor plugin
  4. Navigate to Pages > Sample Page and open the page
  5. Add a feature image
  6. Update to save it
  7. Notice the color of the "Remove featured image" link

Test the fix

  1. Apply the patch: npm run grunt patch:45198
  2. Repeat the rest of the steps from above (expect for the 1st step)

#8 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 50844:

Post Thumbnails: Display the "Remove featured image" link in the classic editor in red color.

This matches the color of the "Move to Trash" link and other similar links for destructive actions in the admin.

Props monikarao, hareesh-pillai, sabernhardt, hellofromTonya.
Fixes #45198.

Note: See TracTickets for help on using tickets.