The latest nightly build keeps telling me to install

[carllockett3]

I'm on 4.9.9-alpha-43656 and today WP informed me there in a new nightly build update. I have installed it multiple times, yet the build number never updates and the message An updated version of WordPress is available.
You are using a development version of WordPress. You can update to the latest nightly build automatically: keeps showing.

Not sure if update installed and the version number was not changed or something else is wrong.

[SergeyBiryukov]

Hi @carllockett3, welcome to WordPress Trac! Thanks for the report.

That's intentional, development versions always show the update message, as they continuously receive nightly updates.

Related: #33262

[knutsp]

While may be intentional, it's not correct unless there is a new nightly build. I have always thought of this as a bug. Ideally it should detect there is actually a new build, or not.

[afragen]

This is clearly by design, though that doesn’t mean that it can’t be more selective about when this notice is displayed.

[afragen]

45202.diff​ moves the notice and update statement to a conditional that checks current version to update version.

I also fixed a number of WPCS issues in the same function.

[afragen]

Shows update-core.php with patch applied

[audrasjb]

As seen during today's bug scrub, the patch looks good to go in 5.2.2 but we'll skip the WPCS changes as we are currently working on a point release.

[afragen]

I’ll get an updated patch done tomorrow when I’m not on call. 😷

[afragen]

remove extra code style fixes

[audrasjb]

Thanks @afragen for the new patch without WPCS enhancements :-)
@SergeyBiryukov 45202.2.diff looks good to go in 5.2.2 on my side 👍

[audrasjb]

Tested with Beta Tester plugin, see screenshots below:

[audrasjb]

before the patch

[audrasjb]

after applying the patch

[SergeyBiryukov]

In my testing, 45202.2.diff​ works when running a nightly build (via Beta Tester plugin or otherwise), but not when running a development version from src or build directory. I think that's an acceptable edge case, let's go with the current patch for now.

For reference:

• Current nightly version: 5.3-alpha-45524
• Current src version: 5.3-alpha-45282-src
• Current build version: 5.3-alpha-20190613.183157

[audrasjb]

As per @azaozz 's feeback in #core Slack channel: "the thing I'm a bit worried about is that we introduce version checking when showing that message. Don't see that done in other cases. It looks OK, but... hard to test in all cases/catch other edge cases"

Then the final decision is this ticket could wait for the next release since this is an edge case in itself for most of WordPress installations. It is now milestoned to WP 5.3.

[azaozz]

Right. Lets do this in trunk first to try to catch any other edge cases.

[azaozz]

In 45532:

Fix displaying of the "An updated version of WordPress is available." notice when running the latest nightly build. Note that it is still displayed when running a local build or from /src.

Props afragen, audrasjb, SergeyBiryukov.
Fixes #45202.