Document all optional parameters as optional in add_image_size()

[DrewAPicture]

The parameter descriptions for the optional $width and $height parameters for add_image_size() are not currently notated as such. Let's fix that.

For guidance on how to document optional parameters, note how the description for the optional fourth parameter, $crop, is formatted.

<?php
 *
 * @param string     $name   Image size identifier.
 * @param int        $width  Image width in pixels.
 * @param int        $height Image height in pixels.
 * @param bool|array $crop   Optional. Whether to crop images to specified width and height or resize.
 *                           An array can specify positioning of the crop area. Default false.
 */
function add_image_size( $name, $width = 0, $height = 0, $crop = false ) {
...

[andrewza]

Patch #45203

[andrewza]

This my first WordPress core commit, hope this is right! Still getting the hang of it! #Contribute!

This patch adjusts the doc block.

[andrewza]

Updated doc block further to include what the variables default to.

[swissspidy]

Assigning the ticket to mark this good-first-bug as claimed.

Thanks for your contribution, @andrewza!

As per ​https://make.wordpress.org/core/2018/10/05/wordpress-5-0-commit-management/ we currently focus on Gutenberg for 5.0, but by the looks of it we can commit this enhancement soon afterwards in the next release.

[pento]

In 43893:

Scripts: Fix a PHP error in admin-ajax calls.

When making an ajax request, wp_enqueue_registered_block_scripts_and_styles() checked if is_admin() was true before accessing $current_screen, rather than checking if $current_screen was defined. This is usually fine, execept for in ajax requests.

Props ocean90, foreverpinetree, pento.
See #45203.

[pento]

Ooops, wrong ticket number in that commit. 🙂

[DrewAPicture]

In 44329:

Docs: Ensure the optional $width and $height parameters are documented as such with defaults in the add_image_size() DocBlock.

Props andrewza.
Fixes #45203.

[andrewza]

Thanks @DrewAPicture, planning on doing more commits for 2019. Hopefully more advanced ones. Have a great day further!

[DrewAPicture]

Great! Look forward to it :-)