Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45208 closed defect (bug) (fixed)

Parameter Coding standard

Reported by: hitendra-chopda's profile Hitendra Chopda Owned by: desrosj's profile desrosj
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Media Keywords: has-patch
Focuses: docs Cc:

Description

When declare the @param int with description than missing the end line coding standard.

I found this bug.

  • @param int $post_id The post_id of the image attachment

should be

  • @param int $post_id The post_id of the image attachment.

as per coding standard.

Attachments (2)

media.patch (702 bytes) - added by Hitendra Chopda 6 years ago.
class-wp-image-editor-gd.patch (563 bytes) - added by Hitendra Chopda 6 years ago.
Here also missing end line period.

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Media
  • Focuses docs added

#2 @Hitendra Chopda
6 years ago

Hello @SergeyBiryukov thank for correct to me for select Component type, Actually this is my first patch.
So let me know if I am wrong any place.
Thanks

@Hitendra Chopda
6 years ago

Here also missing end line period.

This ticket was mentioned in Slack in #core by hitendra-chopda. View the logs.


6 years ago

#4 @Hitendra Chopda
6 years ago

Any one suggest me on my ticket so I can continue with other points.

This ticket was mentioned in Slack in #core by hitendra-chopda. View the logs.


6 years ago

#6 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#7 @desrosj
6 years ago

  • Owner changed from SergeyBiryukov to desrosj

#8 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 44550:

Docs: Add missing periods to param annotations for flip() in WP_Image_Editor_GD.

Props hitendra-chopda.
Fixes #45208.

Note: See TracTickets for help on using tickets.