WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45210 closed defect (bug) (duplicate)

Fix an @see notation in the DocBlock for wp_script_add_data()

Reported by: drewapicture's profile DrewAPicture Owned by: kakomap's profile kakomap
Milestone: Priority: normal
Severity: normal Version:
Component: Script Loader Keywords: good-first-bug has-patch
Focuses: docs Cc:

Description (last modified by DrewAPicture)

The DocBlock for wp_script_add_data() contains a reference to WP_Dependency::add_data(), which unfortunately does not exist. :-)

<?php
 *
 * @see WP_Dependency::add_data()
 *

We need to update the reference to WP_Dependencies::add_data()

Reported by @architchandra.

Attachments (1)

45210.diff​ (483 bytes) - added by kakomap 6 years ago.

Download all attachments as: .zip

Change History (8)

#1 @DrewAPicture
6 years ago

Introduced in [31223].

#2 @DrewAPicture
6 years ago

  • Description modified (diff)

#3 @DrewAPicture
6 years ago

  • Milestone changed from Awaiting Review to Future Release

@kakomap
6 years ago

#4 @kakomap
6 years ago

  • Keywords has-patch added

Hey @DrewAPicture I've submitted something for this

#5 @DrewAPicture
6 years ago

  • Milestone changed from Future Release to 5.1
  • Owner set to kakomap
  • Status changed from new to assigned

Assigning to mark the good-first-bug as "claimed".

Hi @kakomap, thanks for the patch! Everything looks good here.

Trunk development is still ​closed pending the 5.0 release, but we should be able to get this in with 5.1.

#6 @kakomap
6 years ago

Awesome! Looking forward to it...on to more patches it is

#7 @desrosj
6 years ago

  • Milestone 5.1 deleted
  • Resolution set to duplicate
  • Status changed from assigned to closed

Looks like this was fixed in #42505 via [44332].

Note: See TracTickets for help on using tickets.