Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#45223 closed enhancement (fixed)

Use login__in in WP_MS_Users_List_Table

Reported by: spacedmonkey's profile spacedmonkey Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version: 3.1
Component: Users Keywords: has-patch dev-feedback 2nd-opinion
Focuses: multisite Cc:


In WP_MS_Users_List_Table, it runs a raw sql query to get list of super admin user ids. This is no longer required after 4.7, where login__in param was added.

Attachments (1)

45223.diff (908 bytes) - added by spacedmonkey 6 years ago.

Download all attachments as: .zip

Change History (4)

6 years ago

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @pento
5 years ago

  • Milestone changed from 5.1 to 5.2

#3 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 44813:

Users: Use login__in parameter for WP_User_Query in WP_MS_Users_List_Table::prepare_items(), instead of a manual query.

Props spacedmonkey.
Fixes #45223.

Note: See TracTickets for help on using tickets.