Opened 6 years ago
Closed 6 years ago
#45238 closed defect (bug) (fixed)
Twenty Ten: Issues in theme’s Gutenberg support & styles
Reported by: | laurelfulford | Owned by: | laurelfulford |
---|---|---|---|
Milestone: | 5.0 | Priority: | normal |
Severity: | normal | Version: | 5.0 |
Component: | Bundled Theme | Keywords: | has-patch, has-screenshots, commit, dev-reviewed, fixed-5.0 |
Focuses: | Cc: |
Description
I’ve re-reviewed the Gutenberg support that added in #45038, primarily to find anything that might have been missed, but also make sure none of the other changes happening during 5.0 development so far created a need for theme updates, too.
I opted to combine my findings per theme into one ticket, since many of the issues showed up in more than one of the default themes — it seemed like it would make it easier to review and commit these fixes, given the timeline.
In Twenty Ten, I found these issues:
- The placeholder text does not use the correct font styles.
- I’d originally added spacing to the wp-block-columns, which is no longer needed.
- The cover blocks need to have their styles updated to add the newer non
-image-
variations of the cover block classes (.wp-block-cover
and.wp-block-cover-text
) - The Media & Text block does not have spacing underneath it.
- Editor width selectors can be simplified to just use
wp-block
in the Gutenberg 4.2 RC.
Attachments (7)
Change History (13)
@
6 years ago
- Twenty Ten - fixed - columns using the default spacing coming fron Gutenberg styles, not the theme's.
#2
@
6 years ago
- Keywords commit added; needs-testing removed
@laurelfulford I tested this patch and it looks good. Thanks for the second round.
Note: See
TracTickets for help on using
tickets.