WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#45238 closed defect (bug) (fixed)

Twenty Ten: Issues in theme’s Gutenberg support & styles

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch, has-screenshots, commit, dev-reviewed, fixed-5.0
Focuses: Cc:

Description

I’ve re-reviewed the Gutenberg support that added in #45038, primarily to find anything that might have been missed, but also make sure none of the other changes happening during 5.0 development so far created a need for theme updates, too.

I opted to combine my findings per theme into one ticket, since many of the issues showed up in more than one of the default themes — it seemed like it would make it easier to review and commit these fixes, given the timeline.

In Twenty Ten, I found these issues:

  1. The placeholder text does not use the correct font styles.
  2. I’d originally added spacing to the wp-block-columns, which is no longer needed.
  3. The cover blocks need to have their styles updated to add the newer non -image- variations of the cover block classes (.wp-block-cover and .wp-block-cover-text)
  4. The Media & Text block does not have spacing underneath it.
  5. Editor width selectors can be simplified to just use wp-block in the Gutenberg 4.2 RC.

Attachments (7)

twenty-ten-placeholder-font-before.png (12.3 KB) - added by laurelfulford 3 years ago.
1. Twenty Ten - placeholder text does not use correct font
twenty-ten-columns-before.png (112.1 KB) - added by laurelfulford 3 years ago.
2. Twenty Ten - columns with unneeded spacing
twenty-ten-media-text-before.png (209.4 KB) - added by laurelfulford 3 years ago.
4. Twenty Ten - Media & Text block has no spacing underneath
45238.patch (2.3 KB) - added by laurelfulford 3 years ago.
twenty-ten-placeholder-font-after.png (11.8 KB) - added by laurelfulford 3 years ago.
1. Twenty Ten fixed - placeholder text using the correct font
twenty-ten-columns-after.png (148.1 KB) - added by laurelfulford 3 years ago.
2. Twenty Ten - fixed - columns using the default spacing coming fron Gutenberg styles, not the theme's.
twenty-ten-media-text-after.png (209.5 KB) - added by laurelfulford 3 years ago.
4. Twenty Ten - fixed - Media & Text block with spacing

Download all attachments as: .zip

Change History (13)

@laurelfulford
3 years ago

  1. Twenty Ten - placeholder text does not use correct font

@laurelfulford
3 years ago

  1. Twenty Ten - columns with unneeded spacing

@laurelfulford
3 years ago

  1. Twenty Ten - Media & Text block has no spacing underneath

@laurelfulford
3 years ago

@laurelfulford
3 years ago

  1. Twenty Ten fixed - placeholder text using the correct font

@laurelfulford
3 years ago

  1. Twenty Ten - fixed - columns using the default spacing coming fron Gutenberg styles, not the theme's.

@laurelfulford
3 years ago

  1. Twenty Ten - fixed - Media & Text block with spacing

#1 @laurelfulford
3 years ago

  • Owner set to laurelfulford
  • Status changed from new to assigned

#2 @davidakennedy
3 years ago

  • Keywords commit added; needs-testing removed

@laurelfulford I tested this patch and it looks good. Thanks for the second round.

#3 @pento
3 years ago

  • Keywords dev-reviewed added

👍🏻

#4 @laurelfulford
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43869:

Twenty Ten: Fix issues with theme's Gutenberg support.

A handful of issues were missed in Twenty Ten's Gutenberg support, added in #45038. This commit includes the following fixes:

  • Update editor placeholder text to use the correct font family and size.
  • Remove unnecessary spacing from the Columns block.
  • Include non "image" variations of the Cover block classes .wp-block-cover and .wp-block-cover-text in the styles.
  • Add spacing underneath the Media & Text block.
  • Simplify selectors used to set editor width to just .wp-block.

Fixes #45238.

#5 @SergeyBiryukov
3 years ago

  • Keywords fixed-5.0 added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for trunk.

#6 @desrosj
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44152:

Bundled Themes: Expand initial block editor support.

A handful of items were missed when adding initial support for the new block editor to bundled themes in [43793]-[43800]. This adds support for those missed items.

Props pento, davidakennedy, laurelfulford.

Merges [43869], [43870], [43871], [43872], [43873], [43874], [43875], [43876] to trunk.

Fixes #45238, #45239, #45240, #45242, #45243, #45244, #45245, #45246.

Note: See TracTickets for help on using tickets.