Twenty Eleven: Issues in theme’s Gutenberg support & styles

[laurelfulford]

I’ve re-reviewed the Gutenberg support that added in #45039, primarily to find anything that might have been missed, but also make sure none of the other changes happening during 5.0 development so far created a need for theme updates, too.

I opted to combine my findings per theme into one ticket, since many of the issues showed up in more than one of the default themes — it seemed easier for patching and reviewing, given the timeframe.

In Twenty Eleven, I found these issues:

1. Centred widget lists (Categories, Archives…) need to have the text centred, like the editor.
2. The cover blocks need to have their styles updated to add the newer non -image- variations of the cover block classes (.wp-block-cover and .wp-block-cover-text)
3. The Media & Text block does not have spacing underneath it.
4. Editor width selectors can be simplified to just use wp-block in Gutenberg 4.2 RC
5. The margin styles being pulled in from the theme’s original editor styles are causing the content in Gutenberg to sit on the the left. This is new in Gutenberg’s 4.2 RC 1 as well.

[laurelfulford]

1. Centred category widget, not being centred

[laurelfulford]

3. Media & Text block, without spacing underneath it

[laurelfulford]

5. Editor, with content sitting to the left

[laurelfulford]

1. Centred category widget, fixed

[laurelfulford]

3. Media & Text block, after fix

[laurelfulford]

5. Editor alignment, after fix

[laurelfulford]

45239.patch​ addresses all of the issues listed above, though I only included screenshots where it seemed relevant.

[davidakennedy]

@laurelfulford This one looks good as well. Marking it to commit.

[pento]

It looks kind of weird to have the text centred, but the dot points aren't. I'm not sure if centring the points helps, though.

If y'all are happy with the current behaviour, 45239.patch​ is good to commit.

[laurelfulford]

Twenty Eleven - move centred widget bullets to a centred position as well

[laurelfulford]

Twenty Eleven - remove bottom margin from last child in Media & Text block

[laurelfulford]

Thanks @pento & @davidakennedy!

45239.1.patch​ makes sure the bullets are centred with the content in centred widget blocks. It was originally acting inconsistently across browsers -- I personally think the centred bullets look more "right" ("righter"?), so this change should make that consistent across the board.

It also fixes an issue @davidakennedy noted in other tickets, removing the margin from the bottom of the last child of a Media & Text block, which was otherwise adding too much space under the block.

[pento]

💯

[davidakennedy]

The latest patch looks good to me, @laurelfulford.

[laurelfulford]

In 43870:

Twenty Eleven: Fix issues with theme's Gutenberg support.

A handful of issues were missed in Twenty Eleven's Gutenberg support, added in #45039. This commit includes the following fixes:

• Center text and bullets in list-based widget blocks when block itself is centered.
• Include non "image" variations of the Cover block classes .wp-block-cover and .wp-block-cover-text in the styles.
• Add spacing underneath the Media & Text block, but make sure final paragraph in the block doesn't add too much space.
• Simplify selectors used to set editor width to just .wp-block.
• Prevent margin from theme's editor-style.css from interfering with editor alignment.

Props pento, davidakennedy.
Fixes #45239.

[SergeyBiryukov]

Reopening for trunk.

[desrosj]

In 44152:

Bundled Themes: Expand initial block editor support.

A handful of items were missed when adding initial support for the new block editor to bundled themes in [43793]-[43800]. This adds support for those missed items.

Props pento, davidakennedy, laurelfulford.

Merges [43869], [43870], [43871], [43872], [43873], [43874], [43875], [43876] to trunk.

Fixes #45238, #45239, #45240, #45242, #45243, #45244, #45245, #45246.