WordPress.org

Make WordPress Core

#45240 closed defect (bug) (fixed)

Twenty Twelve: Issues in theme’s Gutenberg support & styles

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch, has-screenshots, commit, dev-reviewed, fixed-5.0
Focuses: Cc:
PR Number:

Description

I’ve re-reviewed the Gutenberg support that added in #45040, primarily to find anything that might have been missed, but also make sure none of the other changes happening during 5.0 development so far created a need for theme updates, too.

I opted to combine my findings per theme into one ticket, since many of the issues showed up in more than one of the default themes — it seemed like it would make it easier to review and commit these fixes, given the timeline.

In Twenty Twelve, I found these issues:

  1. The placeholder text does not use the correct font styles.
  2. Centred widget lists (Categories, Archives…) need to have the text centred, like the editor.
  3. The cover blocks need to have their styles updated to add the newer non -image- variations of the cover block classes (.wp-block-cover and .wp-block-cover-text)
  4. The Media & Text block does not have spacing underneath it.
  5. Editor width selectors can be simplified to just use .wp-block in the Gutenberg 4.2 RC.

Attachments (10)

twenty-twelve-placeholder-font-before.png (11.7 KB) - added by laurelfulford 12 months ago.
1. Editor placeholder text, using incorrect font
twenty-twelve-centred-categories-before.png (78.0 KB) - added by laurelfulford 12 months ago.
2. Centred category width, without centred text
twenty-twelve-media-text-before.png (190.0 KB) - added by laurelfulford 12 months ago.
4. Media & Text block without spacing underneath
45240.patch (2.2 KB) - added by laurelfulford 12 months ago.
twenty-twelve-placeholder-font-after.png (11.4 KB) - added by laurelfulford 12 months ago.
1. Editor placeholder text, fixed
twenty-twelve-centred-categories-after.png (85.5 KB) - added by laurelfulford 12 months ago.
2. Centred category widget, fixed
twenty-twelve-media-text-after.png (191.5 KB) - added by laurelfulford 12 months ago.
4. Media & Text block, fixed
45240.1.patch (2.9 KB) - added by laurelfulford 12 months ago.
twenty-twelve-centred-widget-bullet-position.png (30.5 KB) - added by laurelfulford 12 months ago.
Twenty Twelve - move bullets inside when list-based widget block is centred
twenty-twelve-media-text-last-child-bottom-margin.png (179.7 KB) - added by laurelfulford 12 months ago.
Twenty Twelve - remove bottom margin from last child in Media & Text block

Download all attachments as: .zip

Change History (19)

@laurelfulford
12 months ago

  1. Editor placeholder text, using incorrect font

@laurelfulford
12 months ago

  1. Centred category width, without centred text

@laurelfulford
12 months ago

  1. Media & Text block without spacing underneath

@laurelfulford
12 months ago

  1. Editor placeholder text, fixed

@laurelfulford
12 months ago

  1. Centred category widget, fixed

@laurelfulford
12 months ago

  1. Media & Text block, fixed

#1 @laurelfulford
12 months ago

45240.patch should take care of all the issues listed above, though I only included screenshots where it seemed helpful.

#2 @davidakennedy
12 months ago

  • Keywords commit added; needs-testing removed

@laurelfulford This patch looks good. I tested it, and don't see any other issues. Marking it good to go.

#3 @pento
12 months ago

  • Keywords dev-reviewed added

Same thing with the uncentered dot points as in Twenty Eleven, but otherwise, good to go.

@laurelfulford
12 months ago

Twenty Twelve - move bullets inside when list-based widget block is centred

#4 @laurelfulford
12 months ago

Thanks @pento & @davidakennedy!

45240.1.patch makes a couple small updates:

  1. It makes sure bullets are centred when list-based widgets, like the Categories or Archives, are centred.
  2. It fixes an issue @davidakennedy noted in other themes, and removes the bottom margin from the last item in the Media & Text block.

@laurelfulford
12 months ago

Twenty Twelve - remove bottom margin from last child in Media & Text block

#5 @pento
12 months ago

🦆

#6 @davidakennedy
12 months ago

The latest patch looks good to me, @laurelfulford.

#7 @laurelfulford
12 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43871:

Twenty Twelve: Fix issues with theme's Gutenberg support.

A handful of issues were missed in Twenty Twelve's Gutenberg support, added in #45040. This commit includes the following fixes:

  • Update editor placeholder text to use the correct font family.
  • Center text and bullets in list-based widget blocks, when block itself is centered.
  • Include non "image" variations of the Cover block classes .wp-block-cover and .wp-block-cover-text in the styles.
  • Add spacing underneath the Media & Text block, but make sure final paragraph in the block doesn't add too much space.
  • Simplify selectors used to set editor width to just .wp-block.

Props pento, davidakennedy.
Fixes #45240.

#8 @SergeyBiryukov
12 months ago

  • Keywords fixed-5.0 added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for trunk.

#9 @desrosj
10 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44152:

Bundled Themes: Expand initial block editor support.

A handful of items were missed when adding initial support for the new block editor to bundled themes in [43793]-[43800]. This adds support for those missed items.

Props pento, davidakennedy, laurelfulford.

Merges [43869], [43870], [43871], [43872], [43873], [43874], [43875], [43876] to trunk.

Fixes #45238, #45239, #45240, #45242, #45243, #45244, #45245, #45246.

Note: See TracTickets for help on using tickets.