WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45257 closed enhancement (fixed)

Add custom fields support to the block editor

Reported by: noisysocks's profile noisysocks Owned by: pento's profile pento
Milestone: 5.0 Priority: normal
Severity: normal Version: 5.0
Component: Editor Keywords: has-patch fixed-5.0
Focuses: Cc:

Description

The Custom Fields meta box was added to Gutenberg in ​https://github.com/WordPress/gutenberg/pull/11084. We will need to copy the PHP changes over into Core after the @wordpress/edit-post package is updated so that Custom Fields are supported in 5.0.

Attachments (2)

45257.patch​ (4.7 KB) - added by ocean90 6 years ago.
45257.2.patch​ (1011 bytes) - added by ocean90 6 years ago.

Download all attachments as: .zip

Change History (10)

#1 @pento
6 years ago

  • Keywords needs-patch removed
  • Milestone changed from Awaiting Review to 5.0
  • Owner changed from noisysocks to pento

#2 @pento
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43861:

Build Tools: Update the @wordpress packages.

This brings support for the custom fields meta box to the block editor.

The webpack and copy-webpack-plugin packages have also been updated.

See #45145.
Fixes #45257.

@ocean90
6 years ago

@ocean90
6 years ago

#3 @ocean90
6 years ago

  • Keywords has-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

45257.2.patch​ fixes the issue mentioned in ​https://github.com/WordPress/gutenberg/issues/11469.

45257.patch​ adds the brackets to all conditions.

#4 @ocean90
6 years ago

#45281 was marked as a duplicate.

#5 @pento
6 years ago

Thanks for the patch, @ocean90! I'm going to go with the small patch, to make it less tricky when it comes to merging these changes into trunk. :)

#6 @pento
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43863:

Meta Boxes: Add curly brackets missed in [43861].

This was causing the custom meta box to be incorrectly added to post types that don't support it.

Props ocean90, epointal.
Fixes #45257,

#7 @SergeyBiryukov
6 years ago

  • Keywords fixed-5.0 added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for trunk.

#8 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44260:

Editor: Add custom fields meta box support in the block editor.

This brings support for the custom fields meta box into the new block editor.

The webpack and copy-webpack-plugin packages have also been updated.

This does not bump the @wordpress packages like in [43861] because of conflicts with package versions already installed in trunk. The packages will be brought up to date in a subsequent merge.

Merges [43861] and [43863] into trunk.

See #45145.
Fixes #45257.

Note: See TracTickets for help on using tickets.