Changes between Initial Version and Version 1 of Ticket #45264, comment 7
- Timestamp:
- 11/12/2018 07:15:32 AM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #45264, comment 7
initial v1 4 4 I don't mind either way. The idea is to completely remove this from Gutenberg once it starts to require WP 5.0, see https://github.com/WordPress/gutenberg/commit/b814d88612b7c1d4452508aeb9906c98605ca723#diff-f7875e8975dae92862deaf9e0231a93fR118. 5 5 6 The problem is that a new button was introduced to the classic block toolbar that looks the same as the "Toolbar toggle" button but works a bit differently. As far as I understand that was done because the `wordpress` TinyMCE plugin (a core file) needed couple of changes to better support that in Gutenberg. This ticket together with https://github.com/WordPress/gutenberg/pull/10964 fixes the existing `wp_adv` button to work as expected in the classic block.6 The problem is that a new button was introduced to the classic block toolbar that looks the same as the "Toolbar toggle" button but works a bit differently. As far as I understand that was done because the `wordpress` TinyMCE plugin (a core file) needed couple of changes to better support that in Gutenberg. This ticket fixes the existing `wp_adv` button to work as expected in the classic block and https://github.com/WordPress/gutenberg/pull/10964 fixes the similar button in the classic block. 7 7 8 8 The `kitchensink` button in the classic block will be supported for a bit longer and eventually removed.