Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #45264, comment 7


Ignore:
Timestamp:
11/12/2018 07:17:51 AM (5 years ago)
Author:
azaozz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #45264, comment 7

    v1 v2  
    44I don't mind either way. The idea is to completely remove this from Gutenberg once it starts to require WP 5.0, see https://github.com/WordPress/gutenberg/commit/b814d88612b7c1d4452508aeb9906c98605ca723#diff-f7875e8975dae92862deaf9e0231a93fR118.
    55
    6 The problem is that a new button was introduced to the classic block toolbar that looks the same as the "Toolbar toggle" button but works a bit differently. As far as I understand that was done because the `wordpress` TinyMCE plugin (a core file) needed couple of changes to better support that in Gutenberg. This ticket fixes the existing `wp_adv` button to work as expected in the classic block and https://github.com/WordPress/gutenberg/pull/10964 fixes the similar button in the classic block.
     6The problem is that a new button was introduced to the classic block toolbar that looks the same as the "Toolbar toggle" button but works a bit differently. As far as I understand that was done because the `wordpress` TinyMCE plugin (a core file) needed couple of changes to better support that in Gutenberg.
    77
    8 The `kitchensink` button in the classic block will be supported for a bit longer and eventually removed.
     8This ticket fixes the existing `wp_adv` button to work as expected in the classic block and https://github.com/WordPress/gutenberg/pull/10964 fixes the new `kitchensink` button in the classic block so it's removable. That button will be supported for a bit longer and eventually removed.