#45264 closed defect (bug) (fixed)
Fix the TinyMCE `wordpress` plugin to handle toolbars in the classic block
Reported by: | azaozz | Owned by: | azaozz |
---|---|---|---|
Milestone: | 5.0 | Priority: | high |
Severity: | normal | Version: | |
Component: | TinyMCE | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
As the title. The wordpress
plugin throws errors in the classic block when the "Toggle Toolbars" (kitchensink) button is used. Also needs to handle toolbars show/hide there.
Attachments (3)
Change History (15)
#4
@
6 years ago
In 45264.3.diff: also move the show/hide CSS to editor.css (like the rest of the styles for the classic block toolbars). This "fixes" toolbar toggling even with older versions of Gutenberg.
#6
follow-up:
↓ 7
@
6 years ago
- Keywords needs-refresh added; commit removed
@azaozz: The change from GB10964 has landed in Core.
The editor.css
changes in 45264.3.diff should really only be in Gutenberg, Core will get them as part of the package import.
We don't need to worry about supporting old versions of the Gutenberg plugin in the 5.0 branch for this.
#7
in reply to:
↑ 6
@
6 years ago
Replying to pento:
The
editor.css
changes in 45264.3.diff should really only be in Gutenberg,
I don't mind either way. The idea is to completely remove this from Gutenberg once it starts to require WP 5.0, see https://github.com/WordPress/gutenberg/commit/b814d88612b7c1d4452508aeb9906c98605ca723#diff-f7875e8975dae92862deaf9e0231a93fR118.
The problem is that a new button was introduced to the classic block toolbar that looks the same as the "Toolbar toggle" button but works a bit differently. As far as I understand that was done because the wordpress
TinyMCE plugin (a core file) needed couple of changes to better support that in Gutenberg.
This ticket fixes the existing wp_adv
button to work as expected in the classic block and https://github.com/WordPress/gutenberg/pull/10964 fixes the new kitchensink
button in the classic block so it's removable. That button will be supported for a bit longer and eventually removed.
#8
@
6 years ago
- Keywords commit added; needs-refresh removed
Ah, I see. I thought the CSS was applying to the kitchensink
button, but there's not much point in leaving that in Gutenberg if it's just going to be removed.
In that case, 45264.3.diff is good to go!
In 45264.diff: fix handling of toolbar toggle in the
wordpress
TinyMCE plugin.This works together with https://github.com/WordPress/gutenberg/pull/10964, needs to be committed/merged at the same time :)