Changes between Initial Version and Version 1 of Ticket #45282, comment 3
- Timestamp:
- 11/05/2018 03:21:22 AM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #45282, comment 3
initial v1 17 17 1. It wasn't clear to me at first that `wp.editPost.initializeEditor()` was enqueued ''after'' the `block_editor_settings` filter had triggered. Could we move `$init_script`'s declaration in `edit-form-blocks.php:335` closer to where it is used in `edit-form-blocks.php:395`? 18 18 2. Instead of setting `$editor_settings['enableCustomFields']` in `edit-form-blocks.php:300` and then later unsetting it in `edit-form-blocks.php:382`, I think it would be clearer if we conditionally set `enableCustomFields` in the one place after the meta box hook triggers. We do this for other editor settings e.g. `autosave`, `colors`, `fontSizes`. 19 3. What does the change in `templates.php:1079` do?19 3. ~~What does the change in `templates.php:1079` do?~~ Never mind, didn't see your comment!