WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#4532 closed defect (bug) (fixed)

Saving a post with attachments deletes the post's tags

Reported by: filosofo Owned by:
Milestone: 2.3 Priority: high
Severity: major Version: 2.3
Component: Administration Keywords: has-patch, attachment, tags
Focuses: Cc:

Description

Saving a post with attachments calls _fix_attachment_links, which in turn calls wp_update_post, which calls wp_get_single_post, which does not return the tags_input values, so the tags get erased.

My patch gets the tags for wp_get_single_post, which requires an adjustment to the terms api that allows one to request the terms' names.

Attachments (1)

tags_with_attachments_fix.diff (1.6 KB) - added by filosofo 7 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 foolswisdom7 years ago

  • Version set to 2.3

comment:2 ryan7 years ago

  • Priority changed from normal to high

comment:3 follow-up: ryan7 years ago

Still a problem.

comment:4 in reply to: ↑ 3 filosofo7 years ago

Replying to ryan:

Still a problem.

Do you mean the patch doesn't fix it?

comment:5 ryan7 years ago

No, the patch works. Just meant it hadn't been fixed in svn yet after 3 months. Commit on the way.

comment:6 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6121]) Don't lose tags when saving a post with attachments. Props filosofo. fixes #4532

Note: See TracTickets for help on using tickets.