Opened 2 years ago
Last modified 2 years ago
#45329 new defect (bug)
get_post_permalink tries is_wp_error on get_post which it will never be
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Posts, Post Types | Keywords: | needs-patch needs-unit-tests |
Focuses: | Cc: |
Description
get_post_permalink incorrectly calls is_wp_error
on the result of get_post($id)
. Instead it should check for !($post instanceof \WP_Post)
or just $post === false
, since at this location it won't ever be an array either.
Documentation is wrong too - but I assume that's generated from docBlock.
To reproduce: get_post_permalink('whatever-argument-that-does-not-resolve-an-existing-post');
Expected result: return false(or an actual WP_Error but other code like get_permalink()
does not expect it)
Attachments (1)
Change History (2)
Note: See
TracTickets for help on using
tickets.