WordPress.org

Make WordPress Core

#45345 closed defect (bug) (fixed)

Hello Dolly: Don't output lyrics in block editor

Reported by: Joen Owned by:
Milestone: 5.0 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch
Focuses: Cc:
PR Number:

Description

The presentation of the admin_head hook is changing in the block editor screen, leaving no good place to show lyrics. Additionally, the new mobile improvements coming to the block editor break when Hello Dolly is active.

This ticket has a small patch that makes Hello Dolly aware of the block editor, and hides it on that page.

Hello Dolly still graces every other screen in your admin.

Attachments (1)

hello-dolly.diff (915 bytes) - added by Joen 11 months ago.
Hello Dolly patch

Download all attachments as: .zip

Change History (9)

@Joen
11 months ago

Hello Dolly patch

#1 @SergeyBiryukov
11 months ago

  • Milestone changed from Awaiting Review to 5.0

#2 @pento
11 months ago

In 43900:

Hello Dolly: Hide the lyrics in the block editor.

I'm sorry, Hello Dolly. You're my favourite plugin, but the way you output your lyrics doesn't play nicely with the block editor, particuarly on mobile devices.

This isn't Farewell Dolly, you're still on every other admin page, and I know you'll come back better and stronger.

Props joen.
See #45345.

#3 @pento
11 months ago

  • Keywords fixed-5.0 added

#4 @pento
11 months ago

In 43902:

Tests: Update a test that relied on the Hello Dolly plugin version.

[43900] changed the plugin version, causing a unit test failure.

See #45345.

#5 @Joen
11 months ago

Thank you Gary!

#6 @desrosj
10 months ago

In 44229:

Hello Dolly: Hide the lyrics in the block editor.

I'm sorry, Hello Dolly. You're my favorite plugin, but the way you output your lyrics doesn't play nicely with the block editor, particuarly on mobile devices.

This isn't Farewell Dolly, you're still on every other admin page, and I know you'll come back better and stronger.

Merges [43900] to trunk.

Props joen.
See #45345.

#7 @desrosj
10 months ago

In 44230:

Tests: Update a test that relied on the Hello Dolly plugin version.

[43900] changed the plugin version, causing a unit test failure.

Merges [43902] to trunk.

See #45345.

#8 @desrosj
10 months ago

  • Keywords fixed-5.0 removed
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.