WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#45365 closed defect (bug) (fixed)

Block Editor: fix the help modal in the Classic Block

Reported by: azaozz Owned by: azaozz
Priority: normal Milestone: 5.0
Component: TinyMCE Version:
Severity: normal Keywords: has-patch commit fixed-5.0
Cc: Focuses:

Description

Couple of things to fix:

  • Prevent opening the Classic Block/TinyMCE modal and the main help modal at the same time by the Alt+Shift+H keyboard shortcut.
  • Change the name of that modal to indicate it is only for the Classic Block.

Attachments (2)

45365.diff​ (1.9 KB ) - added by azaozz 8 years ago.
45365.2.diff​ (2.1 KB ) - added by azaozz 8 years ago.

Download all attachments as: .zip

Change History (9)

@azaozz
8 years ago

#1 @azaozz
8 years ago

In 45365.diff:

  • Change the title of the keyboard shortcuts modal in the Classic Block instance to "Classic Block Keyboard Shortcuts".
  • Handle the shortcut for opening of the modal with a custom event to stop event bubbling.
Last edited 8 years ago by azaozz (previous) (diff)

@azaozz
8 years ago

#2 @azaozz
8 years ago

In 45365.2.diff: also do not add the Alt+Shift+Z shortcut to the Classic Block. It is used to remove a block in the Block Editor and conflicts.

#3 @azaozz
8 years ago

  • Keywords has-patch commit added

#4 @pento
8 years ago

45365.2.diff​ is good to go.

#5 @azaozz
8 years ago

  • Owner set to azaozz
  • Resolution → fixed
  • Status new → closed

In 43915:

TinyMCE: Fix the keyboard shortcut (Alt+Shift+H) to not open the default Block Editor help modal and change the title of the help modal to "Classic Block Keyboard Shortcuts" in the Classic BLock. Also remove Alt+Shift+Z in the Classic Block as it conflicts with the Block Editor.

Fixes #45365.

#6 @SergeyBiryukov
8 years ago

  • Keywords fixed-5.0 added
  • Resolution fixed
  • Status closed → reopened

Reopening for trunk.

#7 @SergeyBiryukov
8 years ago

  • Resolution → fixed
  • Status reopened → closed

In 44257:

TinyMCE: Fix the keyboard shortcut (Alt+Shift+H) to not open the default Block Editor help modal and change the title of the help modal to "Classic Block Keyboard Shortcuts" in the Classic BLock. Also remove Alt+Shift+Z in the Classic Block as it conflicts with the Block Editor.

Props azaozz.
Merges [43915] to trunk.
Fixes #45365.

Note: See TracTickets for help on using tickets.