WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#45385 closed defect (bug) (wontfix)

Twenty Nineteen: preview for blockquote appears empty

Reported by: Presskopp Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch has-screenshots
Focuses: Cc:

Description

the preview of the second pullquote-style ('large') is just empty:

Attachments (2)

p1.png (5.7 KB) - added by Presskopp 3 years ago.
p2.png (3.1 KB) - added by Presskopp 3 years ago.

Download all attachments as: .zip

Change History (8)

@Presskopp
3 years ago

@Presskopp
3 years ago

#1 @Presskopp
3 years ago

  • Keywords has-screenshots added

#2 @kjellr
3 years ago

Hi @Presskopp —  can you provide more details about your setup? I tried to recreate this, but I'm seeing things a little differently:

https://cldup.com/KIr2OmgdGE.gif

Tested on MacOS 10.14.1, using:

  • Safari 12.0.1
  • Chrome 70.0.3538.102
  • Firefox 63.0.3

Looks the same on both 5.0-beta5-43909, and 4.9.8 running Gutenberg 4.5.1

#3 @kjellr
3 years ago

  • Summary changed from Twenty Nineteen: preview for pullquote appears empty to Twenty Nineteen: preview for blockquote appears empty

Oh wait! This is referencing the blockquote block, not the pullquote block. I'm updating the title so that's more clear.

I see the same in that case. This is likely due to the line-height of the text within the block — I'm not 100% sure we can adjust styles just within the preview there, since they're supposed to be generated automatically.

#4 @Presskopp
3 years ago

I only talk about the 'preview of the preview' - the small bordered window. It appears empty in both cases for the second style variant.

#5 @Presskopp
3 years ago

blockquote.wp-block-quote.is-style-large {
    top: -75px;
    position: relative;
}

This is helping, but doesn't look like a good patch

#6 @laurelfulford
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Thanks for reporting this issue, @Presskopp, and for the testing @kjellr!

It looks like it could be possible to fix this within the theme, but not exactly ideal.

There's currently an issue open in the Gutenberg repo that also addresses this:

https://github.com/WordPress/gutenberg/issues/12956

I'm going to defer to that issue for a fix for now, and close this one as a wontfix within the theme. I'll keep an eye out for how the GitHub issue resolves, and follow up here if needed.

Just let me know if there are any questions about this!

Note: See TracTickets for help on using tickets.