#45386 closed task (blessed) (fixed)
About: Update Freedoms page to include illustrations
Reported by: | melchoyce | Owned by: | gziolo |
---|---|---|---|
Milestone: | 5.0 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Help/About | Keywords: | has-patch commit fixed-5.0 |
Focuses: | ui, administration | Cc: |
Description
@cathibosco has made some great illustrations of the Four Freedoms on https://wordpress.org/about/. Let's bring that over to the admin Freedoms page.
(h/t @boemedia for the suggestion!)
Attachments (4)
Change History (22)
This ticket was mentioned in Slack in #core by melchoyce. View the logs.
6 years ago
#5
@
6 years ago
- Summary changed from Update Freedoms page to include illustrations to About: Update Freedoms page to include illustrations
#7
@
6 years ago
I see background-image: url('https://s.w.org/wp-content/themes/pub/wporg-main/images/freedoms-2x.png');
- this is the only place where we use external URL for an image in CSS files, should we add a local copy?
#8
@
6 years ago
I also noticed when talking with @afercia that the size of the image https://s.w.org/wp-content/themes/pub/wporg-main/images/freedoms-2x.png is big - 472kb. There is also https://s.w.org/wp-content/themes/pub/wporg-main/images/freedoms.png which is 112kb. I would say, let's take the smaller one and double check if we can use SVG instead to make it smaller.
#9
follow-up:
↓ 11
@
6 years ago
The last patch contains a local copy of https://s.w.org/wp-content/themes/pub/wporg-main/images/freedoms.png which is 112kb. It includes a few whitespace fixes for CSS file.
#10
@
6 years ago
I believe optimizing the images and loading from the CDN will be done in tandem with the About Page images prior to final release.
#11
in reply to:
↑ 9
@
6 years ago
Replying to gziolo:
The last patch contains a local copy of https://s.w.org/wp-content/themes/pub/wporg-main/images/freedoms.png which is 112kb. It includes a few whitespace fixes for CSS file.
Tested by applying patch and pulling that image with:
cd /wp-admin/images curl -O https://s.w.org/wp-content/themes/pub/wporg-main/images/freedoms.png
The page looks good on an HiDPI device (Apple MacBook Pro, recent) and in different viewports.
#12
follow-up:
↓ 13
@
6 years ago
I believe optimizing the images and loading from the CDN will be done in tandem with the About Page images prior to final release.
I will commit the previous patch (https://core.trac.wordpress.org/attachment/ticket/45386/45386.2.diff) with CDN version of the image to make sure optimizations are applied everywhere at once.
#13
in reply to:
↑ 12
@
6 years ago
Replying to gziolo:
I believe optimizing the images and loading from the CDN will be done in tandem with the About Page images prior to final release.
I will commit the previous patch (https://core.trac.wordpress.org/attachment/ticket/45386/45386.2.diff) with CDN version of the image to make sure optimizations are applied everywhere at once.
Sounds good, go for it.
#14
@
6 years ago
- Owner set to gziolo
- Resolution set to fixed
- Status changed from new to closed
In 43938:
#15
@
6 years ago
- Keywords fixed-5.0 added
- Milestone changed from Awaiting Review to 5.0
- Resolution fixed deleted
- Status changed from closed to reopened
#16
@
6 years ago
@cathibosco gave me the source files so adding them here if we need those for optimisation: https://www.dropbox.com/s/uugj4so5pqdtskh/Four%20frredoms.zip?dl=0 (apologies for Dropbox but they are large)
#17
@
6 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Merged to trunk in [44264].
Oh my these are lovely! Thanks for adding the work here everyone.