Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45390 closed defect (bug) (duplicate)

Twenty Nineteen theme single post page Countable parameter warning

Reported by: zipal's profile zipal Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Twenty Nineteen theme gives following error on single post page (when we have featured image).

Warning: count(): Parameter must be an array or an object that implements Countable in D:\wamp64\www\wp5\wp-content\themes\twentynineteen\header.php on line 37

I think it's because $discussion is not accessible by the function.
Due to that post title and post meta is not showing up.

Change History (9)

#1 @mukesh27
6 years ago

  • Component changed from General to Bundled Theme
  • Focuses template removed
  • Keywords needs-unit-tests removed
  • Resolution set to invalid
  • Severity changed from major to normal
  • Status changed from new to closed
  • Version 5.0 deleted

Hi @zipal, Welcome to WordPress Trac! Thank you for your ticket.

Twenty Nineteen is currently being developed in its own repository, would you mind submitting this as an issue or PR over there?

https://github.com/WordPress/twentynineteen

#2 @ocean90
6 years ago

  • Milestone Awaiting Review deleted

This ticket was mentioned in Slack in #core by sergey. View the logs.


6 years ago

#4 @kjellr
6 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

Corresponding GitHub ticket:

https://github.com/WordPress/twentynineteen/issues/659

This issue was fixed on GitHub, and then a patch was uploaded to Trac here:

https://core.trac.wordpress.org/attachment/ticket/45424/45424.16.patch

Unfortunately, it didn't make it in for 5.0. The patch should be ready to go for the next release, but I'm going to reopen this ticket so we can continue tracking it here until that happens.

#5 @kjellr
6 years ago

  • Keywords has-patch added

#6 @SergeyBiryukov
6 years ago

  • Milestone set to 5.0.1

#7 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


6 years ago

#9 @pento
6 years ago

  • Milestone 5.0.2 deleted
  • Resolution set to duplicate
  • Status changed from reopened to closed

Duplicate of #45424.

Note: See TracTickets for help on using tickets.