About: Update Privacy page to include illustration

[melchoyce]

May as well make this page match #45386 :)

[garrett-eclipse]

Agreed, let's look into this for 5.6.

[francina]

The patch needs a refresh so it's possible to test it. Thanks!

[Hareesh Pillai]

Refreshed patch against trunk

[Hareesh Pillai]

In 45395.1.diff, I've tried to retain the HTML structure same as the freedoms.php page.

Tested for responsiveness in Google Chrome, and it seems to be fine.

[Hareesh Pillai]

Aside: I noticed a ​Slack comment in reference to a phrase in this page - particularly this part “From time to time, your WordPress site may send data to WordPress.org…”

I guess “may send” should be “sends”?

I think we could evaluate this change as part of this ticket.

[garrett-eclipse]

Minor update to combine aboutsection columns

[garrett-eclipse]

Updated screen

[garrett-eclipse]

Thanks for the refresh @hareesh-pillai I've cleaned it up a little in 45395.2.diff as we don't need to have it in a separate .about_section.column, as well I felt the HR unneeded as it added unnecessary space.

Replying to Hareesh Pillai:

Aside: I noticed a ​Slack comment in reference to a phrase in this page - particularly this part “From time to time, your WordPress site may send data to WordPress.org…”

I guess “may send” should be “sends”?

I think we could evaluate this change as part of this ticket.

Reviewing this may send is valid as you can block those requests on your instance so may is more accurate.

Marking this for final design review, @melchoyce would you like to do the honours?
Once happy with the final image we'll just need to open a meta ticket to have it uploaded to the CDN.

[ryelle]

Patch looks good - my only suggestion before merging would be to give it an alt. Probably an empty alt="", since it's just decorative.

[garrett-eclipse]

Thanks for the feedback @ryelle, the initial patch did have an empty alt="" and we can re-add. Am just curious the benefit there as isn't no-alt the same as an empty alt?
Is that to flag to future developers it was left empty purposefully?

[ryelle]

It's for screen reader users— when a screen reader comes across an image with no alt, it reads the image name (like, "privacy.png"). An empty alt tells the screen reader that this was intentionally blank, and it can safely be skipped when announcing the content.

[garrett-eclipse]

Replying to ryelle:

It's for screen reader users— when a screen reader comes across an image with no alt, it reads the image name (like, "privacy.png"). An empty alt tells the screen reader that this was intentionally blank, and it can safely be skipped when announcing the content.

Thanks @ryelle I appreciate you taking the time to explain that, definitely learned something new there.

[garrett-eclipse]

Update decorative image to include an empty alt to indicate to screen readers not to use the filename.

[garrett-eclipse]

Refresh in 45395.3.diff to add the empty alt="" indicating to screen readers this is a decorative image.

[melchoyce]

Design-wise it looks good to go 👍

[garrett-eclipse]

Privacy Image

[garrett-eclipse]

Refresh to include the image from wp-admin/images/privacy.jpg

[garrett-eclipse]

Hello @melchoyce / @ryelle this is ready for commit.

Attached is the updated diff 45395.4.diff to grab the image locally as well as the image itself;
https://core.trac.wordpress.org/raw-attachment/ticket/45395/privacy.jpg

Note: Dropping mention of CDN as discussion from meta indicated it should live in core as it's not a temporary image.
Meta Slack Discussion: ​https://wordpress.slack.com/archives/C02QB8GMM/p1602098596078400

We also discussed including the Freedoms images in core which can be looked into via #46363.

[garrett-eclipse]

Screenshot of test showing image being sourced locally.

[garrett-eclipse]

Optimized Image (20.9% savings)

[garrett-eclipse]

Not sure if optimizing image needs a new diff... so uploading just in case.

[SergeyBiryukov]

In 49218:

Help/About: Update Privacy page to include illustration.

This brings some consistency with the Freedoms page.

Follow-up to [43938].

Props melchoyce, garrett-eclipse, hareesh-pillai, ryelle.
Fixes #45395.