WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 10 days ago

#45395 closed enhancement (fixed)

About: Update Privacy page to include illustration

Reported by: melchoyce Owned by: garrett-eclipse
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch has-screenshots commit
Focuses: administration, privacy Cc:

Description

May as well make this page match #45386 :)

Attachments (11)

Screen Shot 2018-11-21 at 1.44.42 PM.png (414.0 KB) - added by melchoyce 2 years ago.
45395.diff (2.1 KB) - added by melchoyce 2 years ago.
45395.1.diff (663 bytes) - added by Hareesh Pillai 4 weeks ago.
Refreshed patch against trunk
45395.2.diff (594 bytes) - added by garrett-eclipse 4 weeks ago.
Minor update to combine aboutsection columns
Screen Shot 2020-10-02 at 7.38.06 AM.png (441.6 KB) - added by garrett-eclipse 4 weeks ago.
Updated screen
45395.3.diff (601 bytes) - added by garrett-eclipse 3 weeks ago.
Update decorative image to include an empty alt to indicate to screen readers not to use the filename.
privacy.jpg (266.7 KB) - added by garrett-eclipse 3 weeks ago.
Privacy Image
45395.4.diff (1.0 KB) - added by garrett-eclipse 3 weeks ago.
Refresh to include the image from wp-admin/images/privacy.jpg
Screen Shot 2020-10-07 at 1.18.40 PM.png (694.5 KB) - added by garrett-eclipse 3 weeks ago.
Screenshot of test showing image being sourced locally.
privacy.2.jpg (211.0 KB) - added by garrett-eclipse 3 weeks ago.
Optimized Image (20.9% savings)
45395.5.diff (1.0 KB) - added by garrett-eclipse 3 weeks ago.
Not sure if optimizing image needs a new diff... so uploading just in case.

Download all attachments as: .zip

Change History (29)

@melchoyce
2 years ago

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


2 years ago

This ticket was mentioned in Slack in #core by hareesh-pillai. View the logs.


5 weeks ago

#3 @garrett-eclipse
5 weeks ago

  • Focuses privacy added
  • Milestone changed from Awaiting Review to 5.6

Agreed, let's look into this for 5.6.

#4 @garrett-eclipse
5 weeks ago

  • Owner set to garrett-eclipse
  • Status changed from new to reviewing

#5 @francina
4 weeks ago

  • Keywords needs-refresh added

The patch needs a refresh so it's possible to test it. Thanks!

@Hareesh Pillai
4 weeks ago

Refreshed patch against trunk

#6 @Hareesh Pillai
4 weeks ago

In 45395.1.diff, I've tried to retain the HTML structure same as the freedoms.php page.

Tested for responsiveness in Google Chrome, and it seems to be fine.

#7 follow-up: @Hareesh Pillai
4 weeks ago

Aside: I noticed a Slack comment in reference to a phrase in this page - particularly this part “From time to time, your WordPress site may send data to WordPress.org…”

I guess “may send” should be “sends”?

I think we could evaluate this change as part of this ticket.

#8 @Mista-Flo
4 weeks ago

  • Keywords needs-refresh removed

@garrett-eclipse
4 weeks ago

Minor update to combine aboutsection columns

#9 in reply to: ↑ 7 @garrett-eclipse
4 weeks ago

  • Keywords needs-design-feedback needs-meta-cdn added; needs-testing removed
  • Status changed from reviewing to accepted

Thanks for the refresh @hareesh-pillai I've cleaned it up a little in 45395.2.diff as we don't need to have it in a separate .about_section.column, as well I felt the HR unneeded as it added unnecessary space.

Replying to Hareesh Pillai:

Aside: I noticed a Slack comment in reference to a phrase in this page - particularly this part “From time to time, your WordPress site may send data to WordPress.org…”

I guess “may send” should be “sends”?

I think we could evaluate this change as part of this ticket.

Reviewing this may send is valid as you can block those requests on your instance so may is more accurate.

Marking this for final design review, @melchoyce would you like to do the honours?
Once happy with the final image we'll just need to open a meta ticket to have it uploaded to the CDN.

This ticket was mentioned in Slack in #design by hareesh-pillai. View the logs.


3 weeks ago

#11 @ryelle
3 weeks ago

Patch looks good - my only suggestion before merging would be to give it an alt. Probably an empty alt="", since it's just decorative.

#12 @garrett-eclipse
3 weeks ago

  • Keywords needs-refresh added; needs-design-feedback removed

Thanks for the feedback @ryelle, the initial patch did have an empty alt="" and we can re-add. Am just curious the benefit there as isn't no-alt the same as an empty alt?
Is that to flag to future developers it was left empty purposefully?

#13 follow-up: @ryelle
3 weeks ago

It's for screen reader users— when a screen reader comes across an image with no alt, it reads the image name (like, "privacy.png"). An empty alt tells the screen reader that this was intentionally blank, and it can safely be skipped when announcing the content.

#14 in reply to: ↑ 13 @garrett-eclipse
3 weeks ago

Replying to ryelle:

It's for screen reader users— when a screen reader comes across an image with no alt, it reads the image name (like, "privacy.png"). An empty alt tells the screen reader that this was intentionally blank, and it can safely be skipped when announcing the content.

Thanks @ryelle I appreciate you taking the time to explain that, definitely learned something new there.

@garrett-eclipse
3 weeks ago

Update decorative image to include an empty alt to indicate to screen readers not to use the filename.

#15 @garrett-eclipse
3 weeks ago

  • Keywords needs-refresh removed

Refresh in 45395.3.diff to add the empty alt="" indicating to screen readers this is a decorative image.

#16 @melchoyce
3 weeks ago

Design-wise it looks good to go 👍

@garrett-eclipse
3 weeks ago

Privacy Image

@garrett-eclipse
3 weeks ago

Refresh to include the image from wp-admin/images/privacy.jpg

#17 @garrett-eclipse
3 weeks ago

  • Keywords has-screenshots commit added; needs-meta-cdn removed

Hello @melchoyce / @ryelle this is ready for commit.

Attached is the updated diff 45395.4.diff to grab the image locally as well as the image itself;
https://core.trac.wordpress.org/raw-attachment/ticket/45395/privacy.jpg

Note: Dropping mention of CDN as discussion from meta indicated it should live in core as it's not a temporary image.
Meta Slack Discussion: https://wordpress.slack.com/archives/C02QB8GMM/p1602098596078400

We also discussed including the Freedoms images in core which can be looked into via #46363.

@garrett-eclipse
3 weeks ago

Screenshot of test showing image being sourced locally.

@garrett-eclipse
3 weeks ago

Optimized Image (20.9% savings)

@garrett-eclipse
3 weeks ago

Not sure if optimizing image needs a new diff... so uploading just in case.

#18 @SergeyBiryukov
10 days ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 49218:

Help/About: Update Privacy page to include illustration.

This brings some consistency with the Freedoms page.

Follow-up to [43938].

Props melchoyce, garrett-eclipse, hareesh-pillai, ryelle.
Fixes #45395.

Note: See TracTickets for help on using tickets.