Import from JSON button is missing on Manage All Reusable Blocks page

[noisysocks]

The Import from JSON button is missing on the Manage All Reusable Blocks page and the Export as JSON link underneath each reusable block does not work.

Steps to reproduce

1. Create a new post
2. Create a new reusable block
3. Click on the More button (top right) and select Manage All Reusable Blocks

Expected result

There should be a blue Import from JSON button at the top of the WP Admin page.

[noisysocks]

I've fixed this in 45396.diff by moving wp-list-reusable-blocks to the edit.php page's footer.

[mukesh27]

@noisysocks In WP version 5.0-beta5-43909 is already working without applying above patch. see attached screenshot.

I am missing anything?

[noisysocks]

I think it's a very recent regression. To clarify, I encountered it while running r43933 in the 5.0 branch.

[mukesh27]

Ok. so if above issue fix already then can you please close this ticket or needs to wait?

Replying to noisysocks:

I think it's a very recent regression. To clarify, I encountered it while running r43933 in the 5.0 branch.

[noisysocks]

The issue hasn't been fixed. It exists in the 5.0 development branch. We can't close this ticket until it's fixed by e.g. committing the patch I've attached above.

[youknowriad]

In 43936:

Block Editor: Fix loading the script handling the "Manage Reusable Blocks" page.

This ensures the "import from JSON" and "export JSON" buttons are shown properly.
The script is loaded in the footer because it relies on the DOM being already there.

Props noisysocks, mukesh27.
Fixes #45396.

[swissspidy]

Don't you lose the version number when enqueuing the script that way? Why not just set $scripts->add_data( 'wp-list-reusable-blocks', 'group', 1 ); in script-loader.php instead?

[noisysocks]

Replying to swissspidy:

Don't you lose the version number when enqueuing the script that way? Why not just set $scripts->add_data( 'wp-list-reusable-blocks', 'group', 1 ); in script-loader.php instead?

I wrote the patch the only way I know how—I'm not too familiar with these APIs 🙂

Looking at the source for wp_enqueue_script, it seems to me that calling wp_enqueue_script() with $src = '' and $in_footer = true will have the same effect as setting $script->add_data( 'wp-list-reusable-blocks', 'group', 1 ); in script-loader.php. Is there something I'm missing?

[swissspidy]

The problem with that approach is that for everyone who adds wp-list-reusable-blocks as a dependency or directly calls wp_enqueue_script( 'wp-list-reusable-blocks' ) the script would still load in the header.

That's why this ($script->add_data( 'wp-list-reusable-blocks', 'group', 1 ); should be added directly to the wp_default_packages_scripts function.

[pento]

Thanks for following up on this, and the patch, @swissspidy!

45396.2.diff​ is good to commit.

[swissspidy]

Please correct me if I'm mistaken, but I'd hold off commit until the action on #45402 has been decided as that one includes a revert for this.

[pento]

Yah, I just caught up. :) Re-closing this in favour of #45402.

[youknowriad]

In 43942:

Block Editor: Fix the WordPress packages and vendor script registration.

The version is set properly and the scripts are automatically loaded in the footer.
This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy.
Fixes #45402.
See #45396.

[ocean90]

Duplicate of #45402.

[desrosj]

In 44274:

Block Editor: Fix loading the script handling the "Manage Reusable Blocks" page.

This ensures the "import from JSON" and "export JSON" buttons are shown properly. The script is loaded in the footer because it relies on the DOM being already there.

Props noisysocks, mukesh27.

Merges [43936] into trunk.

Fixes #45396.

[desrosj]

In 44277:

Block Editor: Fix the WordPress packages and vendor script registration.

The version is set properly and the scripts are automatically loaded in the footer.

This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy, youknowriad.

Merges [43942] into trunk.

Fixes #45402.
See #45396.