WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#45398 closed defect (bug) (fixed)

Remove tinymce_version from _WP_Editors::editor_settings()

Reported by: ishitaka's profile ishitaka Owned by: whyisjake's profile whyisjake
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch good-first-bug
Focuses: Cc:

Description

$tinymce_version is not used but it is mentioned in the _WP_Editors::editor_settings() function so needs to remove that global variable declaration.

Attachments (2)

45398.patch​ (611 bytes) - added by ishitaka 6 years ago.
45398.2.diff​ (703 bytes) - added by Mista-Flo 5 years ago.
Fixed patch

Download all attachments as: .zip

Change History (9)

@ishitaka
6 years ago

#1 @ishitaka
6 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core by noisysocks. ​View the logs.
5 years ago

#3 @noisysocks
5 years ago

  • Keywords needs-refresh good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

Thanks @ishitaka. Looks good, but the patch needs to be updated as it no longer applies cleanly.

#4 @SergeyBiryukov
5 years ago

  • Milestone changed from Future Release to 5.5

@Mista-Flo
5 years ago

Fixed patch

#5 @Mista-Flo
5 years ago

  • Keywords needs-refresh removed

I have uploaded a new patch.

#6 @whyisjake
5 years ago

  • Owner set to whyisjake
  • Resolution set to fixed
  • Status changed from new to closed

In 47860:

Editor: Remove TinyMCE global version.

The global variable is not being used in the editor_settings method.

Fixes #45398.
Props ishitaka, noisysocks, mista-flo.

#7 @SergeyBiryukov
5 years ago

In 47861:

Docs: Remove unused @global declarations from _WP_Editors::print_tinymce_scripts().

Follow-up to [47860].

See #45398.

Note: See TracTickets for help on using tickets.