Opened 2 years ago
Closed 2 years ago
#45402 closed defect (bug) (fixed)
Issues in wp_default_packages_scripts()
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.0 | Priority: | normal |
Severity: | minor | Version: | 5.0 |
Component: | Script Loader | Keywords: | has-patch commit fixed-5.0 |
Focuses: | Cc: |
Description
I noticed two issues in wp_default_packages_scripts()
simply by looking at the warnings the IDE threw at me.
First of all, api-fetch
is listed twice in $packages_versions
.
Second, $scripts->add( $handle, $path, $dependencies, false, $version );
is wrong. $version
needs to be the fourth argument. So correct would be $scripts->add( $handle, $path, $dependencies, $version );
.
Attachments (4)
Change History (14)
#3
@
2 years ago
If I'm not mistaken that means all scripts are added to the footer, right? That means the changes made in #45396 are obsolete and would need to be reverted. Otherwise my patch there still applies.
#4
@
2 years ago
If I'm not mistaken that means all scripts are added to the footer, right?
Yes, and I think this is something we did a long time ago. I'm fine reverting the other patch here too.
#7
@
2 years ago
- Owner set to youknowriad
- Resolution set to fixed
- Status changed from new to closed
In 43942:
Good catch @swissspidy I updated the patch with the change in the vendors too and I restored the last argument which was inadvertently removed in #45187
Should be good for me.