Issues in wp_default_packages_scripts()

[swissspidy]

I noticed two issues in wp_default_packages_scripts() simply by looking at the warnings the IDE threw at me.

First of all, api-fetch is listed twice in $packages_versions.
Second, $scripts->add( $handle, $path, $dependencies, false, $version ); is wrong. $version needs to be the fourth argument. So correct would be $scripts->add( $handle, $path, $dependencies, $version );.

[youknowriad]

Good catch @swissspidy I updated the patch with the change in the vendors too and I restored the last argument which was inadvertently removed in #45187

Should be good for me.

[youknowriad]

wait I have a small typo in the diff (damn keyboard) ;)

[swissspidy]

If I'm not mistaken that means all scripts are added to the footer, right? That means the changes made in #45396 are obsolete and would need to be reverted. Otherwise my patch there still applies.

[youknowriad]

If I'm not mistaken that means all scripts are added to the footer, right?

Yes, and I think this is something we did a long time ago. I'm fine reverting the other patch here too.

[youknowriad]

The last patch includes the revert too.

[pento]

👍🏻 on 45402.4.diff​.

[youknowriad]

In 43942:

Block Editor: Fix the WordPress packages and vendor script registration.

The version is set properly and the scripts are automatically loaded in the footer.
This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy.
Fixes #45402.
See #45396.

[ocean90]

#45396 was marked as a duplicate.

[desrosj]

In 44277:

Block Editor: Fix the WordPress packages and vendor script registration.

The version is set properly and the scripts are automatically loaded in the footer.

This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy, youknowriad.

Merges [43942] into trunk.

Fixes #45402.
See #45396.