WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45409 closed defect (bug) (fixed)

Parameter Coding standard not fullfill

Reported by: Hitendra Chopda Owned by: pento
Milestone: 5.1 Priority: normal
Severity: minor Version: 5.1
Component: Administration Keywords: has-patch
Focuses: docs Cc:

Description

When declare the @param int with description than missing the end line coding standard.

I found this bug.

@return int|WP_Error user id of the updated user

should be

@return int|WP_Error user id of the updated user.

should be dot end of the line.

Attachments (5)

user.php.patch (405 bytes) - added by Hitendra Chopda 3 years ago.
user.php.2.patch (584 bytes) - added by Hitendra Chopda 3 years ago.
theme.php.patch (332 bytes) - added by Hitendra Chopda 3 years ago.
Here also missing end line period.
template.php.patch (610 bytes) - added by Hitendra Chopda 3 years ago.
Here also missing end line period.
includes.patch (7.2 KB) - added by Hitendra Chopda 3 years ago.
This is all patches in one file and created patch from the root.

Download all attachments as: .zip

Change History (19)

@Hitendra Chopda
3 years ago

Here also missing end line period.

@Hitendra Chopda
3 years ago

Here also missing end line period.

#1 @ocean90
3 years ago

  • Focuses coding-standards added
  • Keywords has-patch added

#2 @mukesh27
3 years ago

#45411 was marked as a duplicate.

#3 @mukesh27
3 years ago

  • Keywords reporter-feedback added

The patches from #45411 should be added to this one and other patch which you found for same issues.

This ticket was mentioned in Slack in #core by hitendra-chopda. View the logs.


3 years ago

#5 @swissspidy
3 years ago

  • Focuses docs added; coding-standards removed
  • Keywords needs-patch added; has-patch removed

#6 @Hitendra Chopda
3 years ago

I have added all the patches in one file.

Please check attached patch file.

#7 @Hitendra Chopda
3 years ago

I have added all the patches in one file.

Please check attached patch file.

@Hitendra Chopda
3 years ago

This is all patches in one file and created patch from the root.

#8 @swissspidy
3 years ago

Much better, thanks. Although root would mean src/wp-admin/includes/template.php instead of `wp-admin/includes/template.php when using https://github.com/wordpress/wordpress-develop/ for core development.

#9 @swissspidy
3 years ago

  • Keywords has-patch added; reporter-feedback needs-patch removed

#10 @swissspidy
3 years ago

  • Milestone changed from Awaiting Review to 5.1
  • Severity changed from normal to minor

#11 @SergeyBiryukov
3 years ago

  • Component changed from General to Administration

#12 @Hitendra Chopda
3 years ago

  • Version set to trunk

@swissspidy I need to move my patch changes in Github repo?

Thanks

#13 @swissspidy
3 years ago

Just keep it as-is. It‘s fine :)

#14 @pento
3 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 44643:

Docs: Add missing periods to a grab-bag of docblocks.

Props Hitendra Chopda.
Fixes #45409.

Note: See TracTickets for help on using tickets.