Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#45412 closed defect (bug) (duplicate)

Set `svn:eol-style` to `native` for all the new files in 5.0

Reported by: afercia's profile afercia Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:


All the files in the SVN repo need the property svn:eol-style set to native. After a quick investigation, seems many (all?) of these files miss the svn:eol-style property.

This applies to all the new files introduced in WordPress 5.0, including Twenty Nineteen.

Worth noting there are other files in core that miss the svn:eol-style. Seems to me many (all?) files in Twenty Seventeen miss it. Same for some files introduced in recent releases, for example public_html/src/wp-admin/js/code-editor.js. Not sure if these files should be updated now or separately after the 5.0 release.

/Cc @azaozz

Change History (4)

#1 @swissspidy
6 years ago

Could we perhaps add a precommit hook or something to automate this in the future?

#2 @azaozz
5 years ago

  • Milestone changed from 5.0 to Future Release

There is a setting in newer SVN to do that automatically. Precommit hook sounds good too.

Should that be on the 5.0 milestone though? It's a "minor" maintenance thing... Needs to happen for most files in the PHP tests too.

"Coding" text editors for Windows that don't support LF line endings are pretty much non-existent now. Don't think this affects anything else.

Thinking we can do something here after 5.0 is out, maybe the precommit hook? :)

#3 @SergeyBiryukov
5 years ago

Related/duplicate: #42594

#4 @afercia
5 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version 5.0 deleted

This is a duplicate of #42594.

Note: See TracTickets for help on using tickets.