Twenty Nineteen

[allancole]

This is the reference ticket for the Twenty Nineteen theme which is currently under development, ready for 5.0.

Initial development happened on GitHub: ​https://github.com/WordPress/twentynineteen

Read the announcement post: ​https://make.wordpress.org/core/2018/10/16/introducing-twenty-nineteen/

Previous Twenty Nineteen commits, for reference: [43808,43809,43821,43842,43860,43892,43904,43909,43926-43929,43954,43956]

[allancole]

Twenty Nineteen screenshot

[netweb]

Welcome to Trac @allancole and thanks for creating this ticket 🎉

[allancole]

Replying to netweb:

Welcome to Trac @allancole and thanks for creating this ticket 🎉

Thanks @netweb :-)

[allancole]

General code quality and code documentation improvements. Original issue can be found on GitHub: ​https://github.com/WordPress/twentynineteen/pull/546

[allancole]

Fixes a security issue found in a dependency script used in our build tool. The malicious dependency is now removed and no longer called when running npm install or npm run build. More info here: ​https://github.com/WordPress/twentynineteen/pull/675

[allancole]

Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: ​https://github.com/WordPress/twentynineteen/pull/668

[allancole]

Include the non-breaking space override for Hoefler Text on the front end. More info here: ​https://github.com/WordPress/twentynineteen/pull/670

[allancole]

Add nowrap to the columns block at breakpoints above 600px. Fixes #45369. More info here: ​https://github.com/WordPress/twentynineteen/pull/674

[allancole]

Properly set primary color hue theme option. Props richtabor. More info: ​https://github.com/WordPress/twentynineteen/pull/683

[allancole]

Add proper frontend styles for center aligned archive and category blocks. Props richtabor. More info here: ​https://github.com/WordPress/twentynineteen/pull/684

[allancole]

Fix image_filter theme option conditional function. More info here: ​https://github.com/WordPress/twentynineteen/pull/680

[allancole]

Ensure the icons in the classic block toolbar always use dashicons. More info here: ​https://github.com/WordPress/twentynineteen/pull/685

[allancole]

Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. Props richtabor. More info here: ​https://github.com/WordPress/twentynineteen/pull/686

[allancole]

Fix gallery caption link color, Recompile CSS. More info here: ​https://github.com/WordPress/twentynineteen/pull/687

[allancole]

Remove left padding from pullquote blocks. More info here: ​https://github.com/WordPress/twentynineteen/pull/690

[allancole]

Print skip-link-focus-fix inline instead of enqueueing as blocking script. More info here: ​https://github.com/WordPress/twentynineteen/pull/47

[allancole]

Fix and improve some strings with placeholders. More info here: ​https://github.com/WordPress/twentynineteen/pull/217

[allancole]

Fixes some minor code quality issues. More info here: ​https://github.com/WordPress/twentynineteen/pull/237

[allancole]

Fixes some minor code quality issues and adds a few files missing from the previous patch. More info here: ​https://github.com/WordPress/twentynineteen/pull/237

[allancole]

Fix PHP Warning: Parameter must be an array or an object that implements Countable. More info here: ​https://github.com/WordPress/twentynineteen/pull/661

[allancole]

Add missing text domain and escaping to comment author text. More info here: ​https://github.com/WordPress/twentynineteen/pull/274

[allancole]

Update theme screenshot. More info here: ​https://github.com/WordPress/twentynineteen/pull/692

[allancole]

Attached is the updated screenshot referenced in the previous patch.

[allancole]

Remove hyphens rule for cover image text. More info here: ​https://github.com/WordPress/twentynineteen/pull/691

[allancole]

Fix left/right-aligned pullquote spacing. More info here: ​https://github.com/WordPress/twentynineteen/pull/695

[allancole]

Improve readme.txt to follow Theme Review team's new format: More info: ​https://github.com/WordPress/twentynineteen/issues/689 & ​https://make.wordpress.org/themes/handbook/review/required/#readme-txt-file

[allancole]

Revising the fix to add the non-breaking space override for Hoefler Text on the front end. More info here: ​https://github.com/WordPress/twentynineteen/pull/670 (Removes unrelated changes that snuck into 45424.4.patch in a previous patch. It now exclusively addresses the font issue for the frontend alone.)

[allancole]

Revising icons in the classic block toolbar to always use dashicons. More info here: ​https://github.com/WordPress/twentynineteen/pull/685 (This removes some unrelated changes that snuck into 45424.9 in previous patches. It now exclusively addresses the icons issue)

[pento]

In 43961:

Twenty Nineteen: Fix non-breaking spaces being too wide on the front end.

This visual issue had been previously fixed in the block editor, is now fixed in the published post, too.

Props kjellr, allancole.
See #45424.

[pento]

In 43962:

Twenty Nineteen: Fix classic block icons not displaying with non-latin fonts.

Props kjellr, allancole.
See #45424.

[pento]

In 43963:

Twenty Nineteen: Update the screenshot.

The screenshot is now up to date with the theme, and reflects the visuals in the About page.

Props kjellr, allancole.
See #45424.

[pento]

I'm marking this ticket as fixed for 5.0.

Everything else can go in 5.0.x releases.

[pento]

In 44149:

Default Themes: Import Twenty Nineteen from the 5.0 branch.

Merges [43808,43821,43842,43860,43892,43904,43909,43926-43929,43956,43961-43963] from the 5.0 branch to trunk.

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, jorbin, netweb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins, peterwilsoncc, dannycooper, iCaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, grapplerulrich, ocean90, joshfeck, frankew, AbdulWahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, nao, mayukojpn, enodekciw, ketuchetan, atanasangelovdev, poena, sharaz, artisticasad, mukesh27, burhandodhy, crunnells, aprakasa, themeroots, imonly_ik, tlxo, youthkee, brentswisher, smyoon315, mrahmadawais, desideveloper, Kau-Boy, mor10, mikeyarce, dingo_bastard, xkon, twoabove.

Fixes #45424.

[allancole]

The following patches can be ignored for 5.0.2 as they’ve already been included in 5.0:

• 45424.4.1.patch, see: [43961]
• 45424.9.1.patch, see: [43963]
• 45424.4.patch, see: [43961]
• 45424.9.patch, see: [43963]
• 45424.18.patch, see: [43962]

[desrosj]

Working through the remaining patches. 45424.1.patch​ looks good!

[desrosj]

45424.3.patch​ and 45424.5.patch​ are good to go together. There are some changes in the compiled CSS file that are from other changes. We can regenerate the built CSS and commit. @allancole and myself have tested this locally and we are seeing the same resulting diff.

[desrosj]

A refactor of 45424.6.patch that removes the changes committed separately in r44187.

[allancole]

In 44189:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

• Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: ​https://github.com/WordPress/twentynineteen/pull/668
• Add nowrap to the columns block at breakpoints above 600px. More info here: ​https://github.com/WordPress/twentynineteen/pull/674

Props joen, kjellr.

Fixes #45369.

See #45424.

[desrosj]

Removing conflicting changes.

[desrosj]

45424.7.2.patch​ is a clean refreshed 45424.7.patch​ without other changes. Good for commit.

[allancole]

In 44192:

Updating Twenty Nineteen, the new default theme for 2019.

This change properly sets the primary color hue theme option.

• More info: ​https://github.com/WordPress/twentynineteen/pull/683

Props richtabor.

See #45424.

[allancole]

In 44193:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

• Add proper frontend styles for center aligned archive and category blocks. More info here: ​https://github.com/WordPress/twentynineteen/pull/684
• Fix image_filter theme option conditional function. More info here: ​https://github.com/WordPress/twentynineteen/pull/680
• Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. Props richtabor. More info here: ​https://github.com/WordPress/twentynineteen/pull/686

Props richtabor, kjellr.

See #45424.

[desrosj]

In 44196:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fix the gallery caption link color. ​https://github.com/WordPress/twentynineteen/pull/687
• Remove left padding from pullquote blocks. ​https://github.com/WordPress/twentynineteen/pull/690
• Print skip-link-focus-fix inline instead of enqueueing as blocking script. ​https://github.com/WordPress/twentynineteen/pull/47
• Fix and improve some strings with placeholders. ​https://github.com/WordPress/twentynineteen/pull/217

Props kjellr, allancole, dimadin, westonruter.

See #45424.

[desrosj]

In 44199:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fixes some minor code quality issues. ​https://github.com/WordPress/twentynineteen/pull/237
• Fix PHP Warning: Parameter must be an array or an object that implements Countable. ​https://github.com/WordPress/twentynineteen/pull/661
• Add missing text domain and escaping to comment author text. ​https://github.com/WordPress/twentynineteen/pull/274
• Remove hyphens rule for cover image text. ​https://github.com/WordPress/twentynineteen/pull/691

Props khleomix, grapplerulrich, iCaleb, kjellr, allancole.

See #45424.

[desrosj]

In 44201:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fix left/right-aligned pullquote spacing. ​https://github.com/WordPress/twentynineteen/pull/695
• Improve readme.txt to follow the correct standards for themes. ​https://github.com/WordPress/twentynineteen/issues/689

Props kjellr, allancole.

See #45424.

[desrosj]

In 44202:

Twenty Nineteen: Fixes and improvements.

This commit fixes the final differences between the version of Twenty Nineteen in core and the one in GitHub. The two are now identical.

See #45424.

[desrosj]

As of [44202], the GitHub and SVN versions of Twenty Nineteen are identical. I am reopening so the additional commits form today can be merged into trunk, but any changes moving forward should be done through separate tickets.

Changes can be made in bulk by using the compare feature in GitHub to compare the current version in GitHub to master at any time: ​https://github.com/WordPress/twentynineteen/compare/%2099f1f81...master.

[SergeyBiryukov]

Just mentioning [44187] here for merging to trunk (it didn't have the ticket reference):

Updating Twenty Nineteen, the new default theme for 2019.

This change adds general code quality and documentation improvements.

• More info here: ​https://github.com/WordPress/twentynineteen/pull/546

Props grapplerulrich, iCaleb.

[pento]

#45440 was marked as a duplicate.

[pento]

#45390 was marked as a duplicate.

[desrosj]

In 44298:

Twenty Nineteen: Code Quality Improvements.

This change adds general code quality and documentation improvements.

More info here: ​https://github.com/WordPress/twentynineteen/pull/546

Props grapplerulrich, iCaleb, allancole.

Merges [44187] to trunk.

See #45424.

[desrosj]

In 44300:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

• Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: ​https://github.com/WordPress/twentynineteen/pull/668
• Add nowrap to the columns block at breakpoints above 600px. More info here: ​https://github.com/WordPress/twentynineteen/pull/674

Props joen, kjellr, allancole.

Fixes #45369.

Merges [44189] into trunk.

See #45424.

[desrosj]

In 44302:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

• Properly sets the primary color hue theme option. See ​https://github.com/WordPress/twentynineteen/pull/683.
• Add proper frontend styles for center aligned archive and category blocks. See ​https://github.com/WordPress/twentynineteen/pull/684.
• Fix image_filter theme option conditional function. See ​https://github.com/WordPress/twentynineteen/pull/680.
• Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. See ​https://github.com/WordPress/twentynineteen/pull/686.

Props richtabor, kjellr, allancole.

Merges [44192] and [44193] to trunk.

See #45424.

[desrosj]

In 44305:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

• Fix the gallery caption link color. ​https://github.com/WordPress/twentynineteen/pull/687
• Remove left padding from pullquote blocks. ​https://github.com/WordPress/twentynineteen/pull/690
• Print skip-link-focus-fix inline instead of enqueueing as blocking script. ​https://github

.com/WordPress/twentynineteen/pull/47

• Fix and improve some strings with placeholders. ​https://github.com/WordPress/twentynineteen/pull/217
• Fixes some minor code quality issues. ​https://github.com/WordPress/twentynineteen/pull/237
• Fix PHP Warning: Parameter must be an array or an object that implements Countable. ​https://github

.com/WordPress/twentynineteen/pull/661

• Add missing text domain and escaping to comment author text. ​https://github.com/WordPress/twentynineteen/pull/274
• Remove hyphens rule for cover image text. ​https://github.com/WordPress/twentynineteen/pull/691
• Fix left/right-aligned pullquote spacing. ​https://github.com/WordPress/twentynineteen/pull/695
• Improve readme.txt to follow the correct standards for themes. ​https://github.com/WordPress/twentynineteen/issues/689

Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj.

Merges [44196], [44199], and [44201-44202] into trunk.

Fixes #45424.