WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 7 months ago

#45424 closed enhancement (fixed)

Twenty Nineteen

Reported by: allancole Owned by: pento
Milestone: 5.0 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: fixed-5.0
Focuses: Cc:

Description (last modified by SergeyBiryukov)

This is the reference ticket for the Twenty Nineteen theme which is currently under development, ready for 5.0.

Initial development happened on GitHub: https://github.com/WordPress/twentynineteen

Read the announcement post: https://make.wordpress.org/core/2018/10/16/introducing-twenty-nineteen/

Previous Twenty Nineteen commits, for reference: [43808,43809,43821,43842,43860,43892,43904,43909,43926-43929,43954,43956]

Attachments (28)

screenshot.png (817.0 KB) - added by allancole 8 months ago.
Twenty Nineteen screenshot
45424.1.patch (13.0 KB) - added by allancole 8 months ago.
General code quality and code documentation improvements. Original issue can be found on GitHub: https://github.com/WordPress/twentynineteen/pull/546
45424.2.patch (7.3 KB) - added by allancole 8 months ago.
Fixes a security issue found in a dependency script used in our build tool. The malicious dependency is now removed and no longer called when running npm install or npm run build. More info here: https://github.com/WordPress/twentynineteen/pull/675
45424.3.patch (1.4 KB) - added by allancole 8 months ago.
Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: https://github.com/WordPress/twentynineteen/pull/668
45424.4.patch (29.1 KB) - added by allancole 8 months ago.
Include the non-breaking space override for Hoefler Text on the front end. More info here: https://github.com/WordPress/twentynineteen/pull/670
45424.5.patch (16.9 KB) - added by allancole 8 months ago.
Add nowrap to the columns block at breakpoints above 600px. Fixes #45369. More info here: https://github.com/WordPress/twentynineteen/pull/674
45424.6.patch (3.3 KB) - added by allancole 8 months ago.
Properly set primary color hue theme option. Props richtabor. More info: https://github.com/WordPress/twentynineteen/pull/683
45424.7.patch (9.7 KB) - added by allancole 8 months ago.
Add proper frontend styles for center aligned archive and category blocks. Props richtabor. More info here: https://github.com/WordPress/twentynineteen/pull/684
45424.8.patch (721 bytes) - added by allancole 8 months ago.
Fix image_filter theme option conditional function. More info here: https://github.com/WordPress/twentynineteen/pull/680
45424.9.patch (9.7 KB) - added by allancole 8 months ago.
Ensure the icons in the classic block toolbar always use dashicons. More info here: https://github.com/WordPress/twentynineteen/pull/685
45424.10.patch (10.4 KB) - added by allancole 8 months ago.
Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. Props richtabor. More info here: https://github.com/WordPress/twentynineteen/pull/686
45424.11.patch (24.3 KB) - added by allancole 8 months ago.
Fix gallery caption link color, Recompile CSS. More info here: https://github.com/WordPress/twentynineteen/pull/687
45424.12.patch (19.4 KB) - added by allancole 8 months ago.
Remove left padding from pullquote blocks. More info here: https://github.com/WordPress/twentynineteen/pull/690
45424.13.patch (3.1 KB) - added by allancole 8 months ago.
Print skip-link-focus-fix inline instead of enqueueing as blocking script. More info here: https://github.com/WordPress/twentynineteen/pull/47
45424.14.patch (5.7 KB) - added by allancole 8 months ago.
Fix and improve some strings with placeholders. More info here: https://github.com/WordPress/twentynineteen/pull/217
45424.15.patch (1.4 KB) - added by allancole 8 months ago.
Fixes some minor code quality issues. More info here: https://github.com/WordPress/twentynineteen/pull/237
45424.15.1.patch (6.6 KB) - added by allancole 8 months ago.
Fixes some minor code quality issues and adds a few files missing from the previous patch. More info here: https://github.com/WordPress/twentynineteen/pull/237
45424.16.patch (1.3 KB) - added by allancole 8 months ago.
Fix PHP Warning: Parameter must be an array or an object that implements Countable. More info here: https://github.com/WordPress/twentynineteen/pull/661
45424.17.patch (3.0 KB) - added by allancole 8 months ago.
Add missing text domain and escaping to comment author text. More info here: https://github.com/WordPress/twentynineteen/pull/274
45424.18.patch (214 bytes) - added by allancole 8 months ago.
Update theme screenshot. More info here: https://github.com/WordPress/twentynineteen/pull/692
screenshot.2.png (171.4 KB) - added by allancole 8 months ago.
Attached is the updated screenshot referenced in the previous patch.
45424.19.patch (20.1 KB) - added by allancole 8 months ago.
Remove hyphens rule for cover image text. More info here: https://github.com/WordPress/twentynineteen/pull/691
45424.20.patch (39.0 KB) - added by allancole 8 months ago.
Fix left/right-aligned pullquote spacing. More info here: https://github.com/WordPress/twentynineteen/pull/695
45424.21.patch (3.9 KB) - added by allancole 8 months ago.
Improve readme.txt to follow Theme Review team's new format: More info: https://github.com/WordPress/twentynineteen/issues/689 & https://make.wordpress.org/themes/handbook/review/required/#readme-txt-file
45424.4.1.patch (27.8 KB) - added by allancole 8 months ago.
Revising the fix to add the non-breaking space override for Hoefler Text on the front end. More info here: https://github.com/WordPress/twentynineteen/pull/670 (Removes unrelated changes that snuck into 45424.4.patch in a previous patch. It now exclusively addresses the font issue for the frontend alone.)
45424.9.1.patch (1.0 KB) - added by allancole 8 months ago.
Revising icons in the classic block toolbar to always use dashicons. More info here: https://github.com/WordPress/twentynineteen/pull/685 (This removes some unrelated changes that snuck into 45424.9 in previous patches. It now exclusively addresses the icons issue)
45424.6.2.patch (562 bytes) - added by desrosj 7 months ago.
A refactor of 45424.6.patch that removes the changes committed separately in r44187.
45424.7.2.patch (2.1 KB) - added by desrosj 7 months ago.
Removing conflicting changes.

Download all attachments as: .zip

Change History (56)

@allancole
8 months ago

Twenty Nineteen screenshot

This ticket was mentioned in Slack in #core-committers by allancole. View the logs.


8 months ago

#2 follow-up: @netweb
8 months ago

  • Focuses coding-standards removed
  • Milestone changed from Awaiting Review to 5.0

Welcome to Trac @allancole and thanks for creating this ticket 🎉

#3 in reply to: ↑ 2 @allancole
8 months ago

Replying to netweb:

Welcome to Trac @allancole and thanks for creating this ticket 🎉

Thanks @netweb :-)

@allancole
8 months ago

General code quality and code documentation improvements. Original issue can be found on GitHub: https://github.com/WordPress/twentynineteen/pull/546

@allancole
8 months ago

Fixes a security issue found in a dependency script used in our build tool. The malicious dependency is now removed and no longer called when running npm install or npm run build. More info here: https://github.com/WordPress/twentynineteen/pull/675

@allancole
8 months ago

Reverts the customization to the toolbar for wide and full blocks to make them more usable. More info here: https://github.com/WordPress/twentynineteen/pull/668

@allancole
8 months ago

Include the non-breaking space override for Hoefler Text on the front end. More info here: https://github.com/WordPress/twentynineteen/pull/670

@allancole
8 months ago

Add nowrap to the columns block at breakpoints above 600px. Fixes #45369. More info here: https://github.com/WordPress/twentynineteen/pull/674

@allancole
8 months ago

Properly set primary color hue theme option. Props richtabor. More info: https://github.com/WordPress/twentynineteen/pull/683

@allancole
8 months ago

Add proper frontend styles for center aligned archive and category blocks. Props richtabor. More info here: https://github.com/WordPress/twentynineteen/pull/684

@allancole
8 months ago

Fix image_filter theme option conditional function. More info here: https://github.com/WordPress/twentynineteen/pull/680

@allancole
8 months ago

Ensure the icons in the classic block toolbar always use dashicons. More info here: https://github.com/WordPress/twentynineteen/pull/685

@allancole
8 months ago

Remove duplicate rule-line when a separator block is followed by H1/H2 in the editor. Props richtabor. More info here: https://github.com/WordPress/twentynineteen/pull/686

@allancole
8 months ago

Fix gallery caption link color, Recompile CSS. More info here: https://github.com/WordPress/twentynineteen/pull/687

@allancole
8 months ago

Remove left padding from pullquote blocks. More info here: https://github.com/WordPress/twentynineteen/pull/690

@allancole
8 months ago

Print skip-link-focus-fix inline instead of enqueueing as blocking script. More info here: https://github.com/WordPress/twentynineteen/pull/47

@allancole
8 months ago

Fix and improve some strings with placeholders. More info here: https://github.com/WordPress/twentynineteen/pull/217

@allancole
8 months ago

Fixes some minor code quality issues. More info here: https://github.com/WordPress/twentynineteen/pull/237

@allancole
8 months ago

Fixes some minor code quality issues and adds a few files missing from the previous patch. More info here: https://github.com/WordPress/twentynineteen/pull/237

@allancole
8 months ago

Fix PHP Warning: Parameter must be an array or an object that implements Countable. More info here: https://github.com/WordPress/twentynineteen/pull/661

@allancole
8 months ago

Add missing text domain and escaping to comment author text. More info here: https://github.com/WordPress/twentynineteen/pull/274

@allancole
8 months ago

Update theme screenshot. More info here: https://github.com/WordPress/twentynineteen/pull/692

@allancole
8 months ago

Attached is the updated screenshot referenced in the previous patch.

@allancole
8 months ago

Remove hyphens rule for cover image text. More info here: https://github.com/WordPress/twentynineteen/pull/691

@allancole
8 months ago

Fix left/right-aligned pullquote spacing. More info here: https://github.com/WordPress/twentynineteen/pull/695

@allancole
8 months ago

Revising the fix to add the non-breaking space override for Hoefler Text on the front end. More info here: https://github.com/WordPress/twentynineteen/pull/670 (Removes unrelated changes that snuck into 45424.4.patch in a previous patch. It now exclusively addresses the font issue for the frontend alone.)

@allancole
8 months ago

Revising icons in the classic block toolbar to always use dashicons. More info here: https://github.com/WordPress/twentynineteen/pull/685 (This removes some unrelated changes that snuck into 45424.9 in previous patches. It now exclusively addresses the icons issue)

#4 @pento
8 months ago

In 43961:

Twenty Nineteen: Fix non-breaking spaces being too wide on the front end.

This visual issue had been previously fixed in the block editor, is now fixed in the published post, too.

Props kjellr, allancole.
See #45424.

#5 @pento
8 months ago

In 43962:

Twenty Nineteen: Fix classic block icons not displaying with non-latin fonts.

Props kjellr, allancole.
See #45424.

#6 @pento
8 months ago

In 43963:

Twenty Nineteen: Update the screenshot.

The screenshot is now up to date with the theme, and reflects the visuals in the About page.

Props kjellr, allancole.
See #45424.

#7 @pento
8 months ago

  • Keywords fixed-5.0 added

I'm marking this ticket as fixed for 5.0.

Everything else can go in 5.0.x releases.

#8 @SergeyBiryukov
8 months ago

  • Description modified (diff)

#9 @pento
7 months ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 44149:

Default Themes: Import Twenty Nineteen from the 5.0 branch.

Merges [43808,43821,43842,43860,43892,43904,43909,43926-43929,43956,43961-43963] from the 5.0 branch to trunk.

Props allancole, karmatosed, kjellr, yingling017, mrasharirfan, milana_cap, fabiankaegy, westonruter, jorbin, netweb, b-07, khleomix, audrasjb, nielslange, mmaumio, richsalvucci, littlebigthing, dimadin, joyously, anevins, peterwilsoncc, dannycooper, iCaleb, siriokun, technosiren, travel_girl, azchughtai, ianbelanger, nadim1992, ismailelkorchi, nativeinside, chetan200891, grapplerulrich, ocean90, joshfeck, frankew, AbdulWahab610, mendezcode, eliorivero, melchoyce, joen, laurelfulford, mdawaffe, kraftbj, dsmart, nao, mayukojpn, enodekciw, ketuchetan, atanasangelovdev, poena, sharaz, artisticasad, mukesh27, burhandodhy, crunnells, aprakasa, themeroots, imonly_ik, tlxo, youthkee, brentswisher, smyoon315, mrahmadawais, desideveloper, Kau-Boy, mor10, mikeyarce, dingo_bastard, xkon, twoabove.

Fixes #45424.

#10 @allancole
7 months ago

The following patches can be ignored for 5.0.2 as they’ve already been included in 5.0:

Last edited 7 months ago by desrosj (previous) (diff)

#11 @desrosj
7 months ago

Working through the remaining patches. 45424.1.patch looks good!

#12 @desrosj
7 months ago

45424.3.patch and 45424.5.patch are good to go together. There are some changes in the compiled CSS file that are from other changes. We can regenerate the built CSS and commit. @allancole and myself have tested this locally and we are seeing the same resulting diff.

@desrosj
7 months ago

A refactor of 45424.6.patch that removes the changes committed separately in r44187.

#13 @allancole
7 months ago

In 44189:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

Props joen, kjellr.

Fixes #45369.

See #45424.

@desrosj
7 months ago

Removing conflicting changes.

#14 @desrosj
7 months ago

45424.7.2.patch is a clean refreshed 45424.7.patch without other changes. Good for commit.

#15 @allancole
7 months ago

In 44192:

Updating Twenty Nineteen, the new default theme for 2019.

This change properly sets the primary color hue theme option.

Props richtabor.

See #45424.

#16 @allancole
7 months ago

In 44193:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

Props richtabor, kjellr.

See #45424.

#17 @desrosj
7 months ago

In 44196:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

Props kjellr, allancole, dimadin, westonruter.

See #45424.

#18 @desrosj
7 months ago

In 44199:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

Props khleomix, grapplerulrich, iCaleb, kjellr, allancole.

See #45424.

#19 @desrosj
7 months ago

In 44201:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

Props kjellr, allancole.

See #45424.

#20 @desrosj
7 months ago

In 44202:

Twenty Nineteen: Fixes and improvements.

This commit fixes the final differences between the version of Twenty Nineteen in core and the one in GitHub. The two are now identical.

See #45424.

#21 @desrosj
7 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

As of [44202], the GitHub and SVN versions of Twenty Nineteen are identical. I am reopening so the additional commits form today can be merged into trunk, but any changes moving forward should be done through separate tickets.

Changes can be made in bulk by using the compare feature in GitHub to compare the current version in GitHub to master at any time: https://github.com/WordPress/twentynineteen/compare/%2099f1f81...master.

#22 @SergeyBiryukov
7 months ago

Just mentioning [44187] here for merging to trunk (it didn't have the ticket reference):

Updating Twenty Nineteen, the new default theme for 2019.

This change adds general code quality and documentation improvements.

Props grapplerulrich, iCaleb.

#23 @pento
7 months ago

#45440 was marked as a duplicate.

#24 @pento
7 months ago

#45390 was marked as a duplicate.

#25 @desrosj
7 months ago

In 44298:

Twenty Nineteen: Code Quality Improvements.

This change adds general code quality and documentation improvements.

More info here: https://github.com/WordPress/twentynineteen/pull/546

Props grapplerulrich, iCaleb, allancole.

Merges [44187] to trunk.

See #45424.

#26 @desrosj
7 months ago

In 44300:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

Props joen, kjellr, allancole.

Fixes #45369.

Merges [44189] into trunk.

See #45424.

#27 @desrosj
7 months ago

In 44302:

Updating Twenty Nineteen, the new default theme for 2019.

This update changes the following:

Props richtabor, kjellr, allancole.

Merges [44192] and [44193] to trunk.

See #45424.

#28 @desrosj
7 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44305:

Twenty Nineteen: Fixes and improvements.

This commit brings over several changes that occurred upstream in the theme’s GitHub repository into core.

.com/WordPress/twentynineteen/pull/47

.com/WordPress/twentynineteen/pull/661

Props kjellr, allancole, dimadin, westonruter, khleomix, grapplerulrich, iCaleb, desrosj.

Merges [44196], [44199], and [44201-44202] into trunk.

Fixes #45424.

Note: See TracTickets for help on using tickets.