WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#45427 closed defect (bug) (fixed)

Twenty Sixteen: Button blocks don't apply custom colours

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch has-screenshots commit fixed-5.0
Focuses: Cc:

Description

The selectors used for Twenty Sixteen's button blocks are too specific, the styles for the editor custom colours don't override them on the front-end.

Attachments (4)

twenty-sixteen-colors-editor.png (60.1 KB) - added by laurelfulford 2 years ago.
Twenty Sixteen - custom colours applied in editor
twenty-sixteen-colors-front-end-before.png (57.9 KB) - added by laurelfulford 2 years ago.
Twenty Sixteen - custom colours not being applied to the front end.
45427.patch (3.4 KB) - added by laurelfulford 2 years ago.
twenty-sixteen-colors-front-end-after.png (57.6 KB) - added by laurelfulford 2 years ago.
Twenty Sixteen - custom colours applied on front-end after patch

Download all attachments as: .zip

Change History (14)

@laurelfulford
2 years ago

Twenty Sixteen - custom colours applied in editor

@laurelfulford
2 years ago

Twenty Sixteen - custom colours not being applied to the front end.

@laurelfulford
2 years ago

@laurelfulford
2 years ago

Twenty Sixteen - custom colours applied on front-end after patch

#1 @laurelfulford
2 years ago

45427.patch adjusts the selectors used to apply background and text colours to the button block, and the selectors used to apply the custom colours. This makes sure the selected colours override the button's default colours.

#2 @laurelfulford
2 years ago

  • Milestone changed from Awaiting Review to 5.0

#3 @davidakennedy
2 years ago

  • Keywords commit added; needs-testing removed

Hey @laurelfulford! Thanks for this – tested and it looks good to go.

#4 @laurelfulford
2 years ago

  • Milestone changed from 5.0 to 5.0.1

#5 @Joen
2 years ago

Patch looks good 👍 👍! 🌹

#6 @pento
2 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#7 @laurelfulford
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44200:

Twenty Sixteen: Fix button block custom colors on front end.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Fixes #45427.

#8 @desrosj
2 years ago

  • Keywords fixed-5.0 added

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

#9 @SergeyBiryukov
2 years ago

  • Keywords changed from has-patch, has-screenshots, commit, fixed-5.0 to has-patch has-screenshots commit fixed-5.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

#10 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Merged to trunk in [44306].

Note: See TracTickets for help on using tickets.