WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45429 closed defect (bug) (fixed)

Twenty Fourteen: Button blocks don't apply custom colours

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch has-screenshots commit fixed-5.0
Focuses: Cc:

Description

The selectors used for Twenty Fourteen's button blocks are too specific, the styles for the editor custom colours don't override them on the front-end.

Attachments (4)

twenty-fourteen-custom-colors-editor.png (44.1 KB) - added by laurelfulford 3 years ago.
Twenty Fourteen - custom colours applied in editor
twenty-fourteen-custom-colors-front-end-before.png (46.6 KB) - added by laurelfulford 3 years ago.
Twenty Fourteen - custom colours on front end, before
45429.patch (945 bytes) - added by laurelfulford 3 years ago.
twenty-fourteen-custom-colors-front-end-after.png (47.3 KB) - added by laurelfulford 3 years ago.
Twenty Fourteen - custom colours on front end, after

Download all attachments as: .zip

Change History (13)

@laurelfulford
3 years ago

Twenty Fourteen - custom colours applied in editor

@laurelfulford
3 years ago

Twenty Fourteen - custom colours on front end, before

@laurelfulford
3 years ago

@laurelfulford
3 years ago

Twenty Fourteen - custom colours on front end, after

#1 @laurelfulford
3 years ago

45429.patch moves the colour and background colours on the button to a slightly less specific selector, so the custom colours can override them.

#2 @davidakennedy
3 years ago

  • Keywords commit added; needs-testing removed

Hey @laurelfulford, tested this one, and it's good to go.

#3 @laurelfulford
3 years ago

  • Milestone changed from 5.0 to 5.0.1

#4 @Joen
3 years ago

Patch looks good 👍 👍! And these buttons look particularly amazing. Big fan.

#5 @pento
3 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @laurelfulford
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44197:

Twenty Fourteen: Fix button block custom colors on front end.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Fixes #45429.

#7 @desrosj
3 years ago

  • Keywords fixed-5.0 added

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

#8 @SergeyBiryukov
3 years ago

  • Keywords changed from has-patch, has-screenshots, commit, fixed-5.0 to has-patch has-screenshots commit fixed-5.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44306:

Bundled Themes: Fix button block custom colors on front end.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

This fix is applied to Twenty Sixteen, Twenty Fifteen and Twenty Fourteen.

Props laurelfulford.

Merges [44197-44198] and [44200] into trunk.

Fixes #45428, #45429.

Note: See TracTickets for help on using tickets.