WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45431 closed defect (bug) (fixed)

Twenty Thirteen: Button blocks don't apply custom colours

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch has-screenshots commit fixed-5.0
Focuses: Cc:

Description

The selectors used for Twenty Thirteen's button blocks are too specific, the styles for the editor custom colours don't override them on the front-end.

The styles also include a gradient that overrides the background custom colour, both on the front-end and in the editor.

Attachments (5)

twenty-thirteen-custom-colors-editor-before.png (22.7 KB) - added by laurelfulford 3 years ago.
Twenty Thirteen - custom colours in editor before
twenty-thirteen-custom-colors-front-end-before.png (22.1 KB) - added by laurelfulford 3 years ago.
Twenty Thirteen - custom colours on front-end, before
45431.patch (5.5 KB) - added by laurelfulford 3 years ago.
twenty-thirteen-custom-colors-editor-after.png (22.3 KB) - added by laurelfulford 3 years ago.
Twenty Thirteen - custom colours in editor, after
twenty-thirteen-custom-colors-front-end-after.png (20.4 KB) - added by laurelfulford 3 years ago.
Twenty Thirteen - custom colours on front-end, after

Download all attachments as: .zip

Change History (14)

@laurelfulford
3 years ago

Twenty Thirteen - custom colours in editor before

@laurelfulford
3 years ago

Twenty Thirteen - custom colours on front-end, before

@laurelfulford
3 years ago

@laurelfulford
3 years ago

Twenty Thirteen - custom colours in editor, after

@laurelfulford
3 years ago

Twenty Thirteen - custom colours on front-end, after

#1 @laurelfulford
3 years ago

45431.patch updates the button block styles, to make the selectors where the colours are applied on the front end less specific.

It also makes sure the gradient is only applied when there is no custom background colour, both in the editor and front end.

Lastly, it appends the .entry-content class to the custom colours, to make them more specific.

#2 @davidakennedy
3 years ago

  • Keywords commit added; needs-testing removed

@laurelfulford Thanks for the patch. Looks good!

#3 @laurelfulford
3 years ago

  • Milestone changed from 5.0 to 5.0.1

#4 @Joen
3 years ago

Patch looks good 👍 👍! Gosh, this takes me back. I owe you a milkshake, let the record show.

#5 @pento
3 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @laurelfulford
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44195:

Twenty Thirteen: Fix button block custom colors.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Also make sure the button’s gradient is not applied when a custom background color is added, since it will hide it.

Fixes #45431.

#7 @desrosj
3 years ago

  • Keywords fixed-5.0 added

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

#8 @SergeyBiryukov
3 years ago

  • Keywords changed from has-patch, has-screenshots, commit, fixed-5.0 to has-patch has-screenshots commit fixed-5.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44304:

Twenty Thirteen: Fix button block custom colors.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Also make sure the button’s gradient is not applied when a custom background color is added, since it will hide it.

Props laurelfulford.

Merges [44195] into trunk.

Fixes #45431.

Note: See TracTickets for help on using tickets.