Twenty Twelve: Button blocks don't apply custom colours

[laurelfulford]

The selectors used for Twenty Twelve's button blocks are too specific, the styles for the editor custom colours don't override them on the front-end.

The styles also include a gradient that overrides the background custom colour, both on the front-end and in the editor.

[laurelfulford]

Twenty Twelve - custom colours in editor, before.

[laurelfulford]

Twenty Twelve - custom colours on front end, before

[laurelfulford]

Twenty Twelve - custom colours in editor, after.

[laurelfulford]

Twenty Twelve - custom colours on front end, after

[laurelfulford]

45432.patch​ adjusts the specificity of the button colour selectors for the front end, so the custom colours can override them. It also takes the :visited colours into account, so the custom colours can also override them to make sure there's enough contrast.

Lastly, it makes it so the button gradient is only applied when there is no background colour, so it doesn't cover it up in the editor and on the front end.

[davidakennedy]

Hey @laurelfulford, took this patch for a spin and it's good to go.

[Joen]

Patch looks good 👍 👍! ⛴🛳🚢

[laurelfulford]

In 44194:

Twenty Twelve: Fix button block custom colors.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Also make sure the button’s gradient is not applied when a custom background color is added, since it will hide it.

Fixes #45432.

[desrosj]

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

[desrosj]

In 44303:

Twenty Twelve: Fix button block custom colors.

Simplify some of the button block’s CSS selectors in the theme, to make sure the default colors don’t override the custom colors on the front end.

Also make sure the button’s gradient is not applied when a custom background color is added, since it will hide it.

Props laurelfulford.

Merges [44194] to trunk.

Fixes #45432.