WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45434 closed defect (bug) (fixed)

Twenty Ten: Visited link colours override custom colours

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch has-screenshots commit fixed-5.0
Focuses: Cc:

Description

In Twenty Ten, the visited link styles (purple text) override the less-specific custom colours. This is especially problematic when the link is in a button with a dark background, since it's difficult to read.

Attachments (3)

twenty-ten-visited-button-links-before.png (50.5 KB) - added by laurelfulford 3 years ago.
Twenty Ten - buttons; the first one uses the default colours, the rest use custom backgrounds and text colours.
45434.patch (1.5 KB) - added by laurelfulford 3 years ago.
twenty-ten-visited-button-links-after.png (50.2 KB) - added by laurelfulford 3 years ago.
Twenty Ten - buttons; the first one uses the default colours, the rest use custom backgrounds and text colours - after fix.

Download all attachments as: .zip

Change History (12)

@laurelfulford
3 years ago

Twenty Ten - buttons; the first one uses the default colours, the rest use custom backgrounds and text colours.

@laurelfulford
3 years ago

@laurelfulford
3 years ago

Twenty Ten - buttons; the first one uses the default colours, the rest use custom backgrounds and text colours - after fix.

#1 @laurelfulford
3 years ago

45434.patch adds a visited state to the custom colour selectors, so they override the theme's visited link styles.

#2 @davidakennedy
3 years ago

  • Keywords commit added; needs-testing removed

@laurelfulford This is good to go. Good catch, as I don't think this was done in laters default themes.

#3 @laurelfulford
3 years ago

  • Milestone changed from 5.0 to 5.0.1

#4 @Joen
3 years ago

Patch looks good 👍 👍! Thank you for all your work.

#5 @pento
3 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @laurelfulford
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44188:

Twenty Ten: Custom colors should override :visited link styles on blocks.

Make sure the block editor custom colors in the theme also override the theme's :visited link styles. This prevents contrast issues, like in the button block -- when the background is dark, the purple :visited link can be difficult to read.

Fixes #45434.

#7 @desrosj
3 years ago

  • Keywords fixed-5.0 added

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

#8 @SergeyBiryukov
3 years ago

  • Keywords changed from has-patch, has-screenshots, commit, fixed-5.0 to has-patch has-screenshots commit fixed-5.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44299:

Twenty Ten: Custom colors should override :visited link styles on blocks.

Make sure the block editor custom colors in the theme also override the theme's :visited link styles. This prevents contrast issues, like in the button block -- when the background is dark, the purple :visited link can be difficult to read.

Props laurelfulford.

Merges [44188] into trunk.

Fixes #45434.

Note: See TracTickets for help on using tickets.