Opened 6 years ago
Closed 3 years ago
#45438 closed enhancement (fixed)
All Settings page (options.php), message when saved
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.0 | Priority: | normal |
Severity: | minor | Version: | |
Component: | Options, Meta APIs | Keywords: | good-first-bug needs-testing has-patch |
Focuses: | Cc: |
Description
Even if saving fails beyond the number of items limit (max_input_vars) in the All Settings page (/wp-admin/options.php), it will be displayed as "Settings saved." It is necessary to display an error message.
(Related to the discussion in #25939)
Attachments (3)
Change History (14)
#1
@
6 years ago
- Keywords needs-patch good-first-bug added; 2nd-opinion removed
- Milestone changed from Awaiting Review to Future Release
#3
@
6 years ago
Trunk still has a pre-gutenberg version so I think I should wait until it updates to test this?
While I'm waiting, as a newbie, may I ask how I'm going to get a save error in order to test that your patch works properly? Or do I just need to edit and save a post a few times to be sure it doesn't cause problems?
#5
@
6 years ago
- Milestone changed from Future Release to 5.1
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
This ticket was mentioned in Slack in #core by sergey. View the logs.
3 years ago
#9
@
3 years ago
45438.2.patch looks good, 45438.diff is identical with a minor coding standards fix.
Testing notes
System
WordPress 6.0-alpha-52448-src
PHP-FPM 7.4
nginx
PHP Config: max_input_vars
set to 10
.
Before
- Saving
wp-admin/options.php
shows as successful - Database did not update due to exceeding
max_input_vars
After
- Saving
wp-admin/options.php
shows an error message - Behaviour unchanged after removing change to
max_input_vars
✓ working as expected
It would be great to get this fixed. Once there is a patch to discuss, we should move it into the relevant milestone.