WordPress.org

Make WordPress Core

Opened 14 months ago

Last modified 13 months ago

#45438 reviewing enhancement

All Settings page (options.php), message when saved

Reported by: ishitaka Owned by: SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: minor Version:
Component: Options, Meta APIs Keywords: good-first-bug needs-testing has-patch
Focuses: Cc:
PR Number:

Description

Even if saving fails beyond the number of items limit (max_input_vars) in the All Settings page (/wp-admin/options.php), it will be displayed as "Settings saved." It is necessary to display an error message.

(Related to the discussion in #25939)

Attachments (2)

45438.patch​ (1.2 KB) - added by ishitaka 14 months ago.
45438.2.patch​ (888 bytes) - added by ishitaka 14 months ago.

Download all attachments as: .zip

Change History (8)

#1 @jorbin
14 months ago

  • Keywords needs-patch good-first-bug added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to Future Release

It would be great to get this fixed. Once there is a patch to discuss, we should move it into the relevant milestone.

@ishitaka
14 months ago

@ishitaka
14 months ago

#2 @ishitaka
14 months ago

  • Keywords needs-testing added

Sorry, 45438.patch is a mistake.

#3 @maguijo
14 months ago

Trunk still has a pre-gutenberg version so I think I should wait until it updates to test this?

While I'm waiting, as a newbie, may I ask how I'm going to get a save error in order to test that your patch works properly? Or do I just need to edit and save a post a few times to be sure it doesn't cause problems?

#4 @maguijo
14 months ago

  • Keywords has-patch added; needs-patch removed

#5 @SergeyBiryukov
14 months ago

  • Milestone changed from Future Release to 5.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#6 @pento
13 months ago

  • Milestone changed from 5.1 to Future Release

Needs testing and review.

Note: See TracTickets for help on using tickets.