Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#45442 closed defect (bug) (duplicate)

Block editor: load wp-block-library as a dependency of wp-edit-blocks

Reported by: Joen Owned by: youknowriad
Priority: normal Milestone:
Component: Editor Version:
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

In Gutenberg, there is an inconsistency in the RC release compared to the plugin release, as to the load order of the block CSS.

This is causing an issue specifically with the columns block, where a focused paragraph inside a columns block collapses.

If we add wp-block-library to the dependencies of wp-edit-blocks, the issue is fixed.

Attachments (1)

block-css-dependency.diff (450 bytes ) - added by Joen 8 years ago.

Download all attachments as: .zip

Change History (16)

#1 @desrosj
8 years ago

  • Milestone Awaiting Review5.0

#2 @desrosj
8 years ago

  • Component GeneralEditor

This ticket was mentioned in Slack in #core by chanthaboune. View the logs.


8 years ago

#4 @matt
8 years ago

Fine for 5.0.1, not a blocker for 5.0.

#5 @pento
8 years ago

  • Milestone 5.05.0.1

#6 @jorgefilipecosta
8 years ago

#45490 was marked as a duplicate.

#7 @afercia
8 years ago

For history: more details, screenshots, and GIFs on https://github.com/WordPress/gutenberg/issues/11159

#8 @pento
8 years ago

  • Milestone 5.0.15.0.2

#9 @youknowriad
8 years ago

  • Owner set to youknowriad
  • Resolutionfixed
  • Status newclosed

In 44183:

Block Editor: Upgrade @wordpress packages to the latest version (4.7).

Updated packages:

  • @wordpress/annotations@1.0.4
  • @wordpress/api-fetch@2.2.6
  • @wordpress/block-library@2.2.10
  • @wordpress/block-serialization-default-parser@2.0.2
  • @wordpress/block-serialization-spec-parser@2.0.2
  • @wordpress/blocks@6.0.4
  • @wordpress/components@7.0.4
  • @wordpress/core-data@2.0.15
  • @wordpress/data@4.1.0
  • @wordpress/date@3.0.1
  • @wordpress/edit-post@3.1.5
  • @wordpress/editor@9.0.5
  • @wordpress/eslint-plugin@1.0.0
  • @wordpress/format-library@1.2.8
  • @wordpress/html-entities@2.0.4
  • @wordpress/list-reusable-blocks@1.1.17
  • @wordpress/notices@1.1.1
  • @wordpress/nux@3.0.5
  • @wordpress/rich-text@3.0.3
  • @wordpress/url@2.3.2
  • @wordpress/viewport@2.0.13

This also includes the updates the Core blocks.
The script loader is updated to match the Gutenberg repository too.

Props atimmer, gziolo, joen.
Fixes #45442, #45637.

#10 @youknowriad
8 years ago

  • Resolution fixedduplicate

This fix is included in the last package update. See #45637.

#11 @desrosj
8 years ago

  • Keywords fixed-5.0 added

Reopening and marking fixed-5.0 so that this can be properly merged into trunk.

#12 @SergeyBiryukov
8 years ago

  • Keywords has-patch, fixed-5.0 → has-patch fixed-5.0
  • Resolution duplicate
  • Status closedreopened

#13 @SergeyBiryukov
8 years ago

  • Keywords fixed-5.0 removed
  • Milestone 5.0.2
  • Resolutionduplicate
  • Status reopenedclosed

On second thought, seems like we already have #45637 as a tracking ticket for this.

#14 @desrosj
8 years ago

  • Resolution duplicatefixed

In 44296:

Block Editor: Upgrade @wordpress packages to match version 4.7.1.

Updated packages:

  • `@wordpress/annotations
  • `@wordpress/api-fetch
  • `@wordpress/block-library@2.2.10
  • @wordpress/block-serialization-default-parser@2.0.2
  • @wordpress/block-serialization-spec-parser@2.0.2
  • @wordpress/blocks@6.0.4
  • @wordpress/components@7.0.4
  • @wordpress/core-data@2.0.15
  • @wordpress/data@4.1.0
  • @wordpress/date@3.0.1
  • @wordpress/edit-post@3.1.5
  • @wordpress/editor@9.0.5
  • @wordpress/eslint-plugin@1.0.0
  • @wordpress/format-library@1.2.8
  • @wordpress/html-entities@2.0.4
  • @wordpress/list-reusable-blocks@1.1.17
  • @wordpress/notices@1.1.1
  • @wordpress/nux@3.0.5
  • @wordpress/rich-text@3.0.3
  • @wordpress/url@2.3.2
  • @wordpress/viewport@2.0.13

This also includes the updates the Core blocks.

The script loader is updated to match the Gutenberg repository as well.

Props atimmer, gziolo, joen, youknowriad.

Merges [44183] to trunk.

Fixes #45442, #45637.

#15 @ocean90
8 years ago

  • Resolution fixedduplicate
Note: See TracTickets for help on using tickets.