WordPress.org

Make WordPress Core

Opened 11 months ago

Last modified 6 months ago

#45447 accepted defect (bug)

Add Embed Preview support for classic embed providers

Reported by: swissspidy Owned by: kadamwhite
Milestone: Future Release Priority: normal
Severity: normal Version: 5.0
Component: Embeds Keywords: has-patch has-unit-tests dev-feedback
Focuses: rest-api Cc:
PR Number:

Description

In #45142 we ported over the logic from gutenberg_filter_oembed_result() directly to core in \WP_oEmbed_Controller::get_proxy_item().

However, we somehow missed to add the changes from https://github.com/WordPress/gutenberg/pull/6345 as well. Basically, we didn't use the most up to date version of gutenberg_filter_oembed_result().

We also need to call \WP_Embed::shortcode() in \WP_oEmbed_Controller::get_proxy_item() to add back support for classic embeds.

Attachments (2)

45447.diff (1.2 KB) - added by swissspidy 11 months ago.
45447.2.diff (3.0 KB) - added by swissspidy 9 months ago.

Download all attachments as: .zip

Change History (21)

@swissspidy
11 months ago

#1 @swissspidy
11 months ago

  • Keywords needs-unit-tests added

45447.diff is an untested copy of the current gutenberg_filter_oembed_result() function.

#2 @pento
10 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#3 @swissspidy
10 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

#4 @pento
10 months ago

  • Keywords needs-unit-tests needs-testing removed
  • Owner set to pento
  • Status changed from new to assigned

#5 @pento
10 months ago

  • Keywords needs-unit-tests needs-testing added
  • Milestone changed from 5.0.2 to 5.0.3
  • Owner pento deleted

Accidentally changed the keywords on this. :)

#6 @swissspidy
10 months ago

#45757 was marked as a duplicate.

#7 @audrasjb
10 months ago

  • Milestone changed from 5.0.3 to 5.1

5.0.3 is going to be released in a couple of weeks. We are currently sorting the remaining tickets in the milestone. It doesn't appear that ticket can be handled in the next couple of weeks (still needs testing and unit-tests). Let's address it in 5.1 which is coming in February. Feel free to change/ask to change the milestone if you think the issue can be quickly resolved.

@swissspidy
9 months ago

#8 @swissspidy
9 months ago

  • Keywords has-unit-tests dev-feedback added; needs-unit-tests needs-testing removed

This ticket was mentioned in Slack in #core-restapi by desrosj. View the logs.


9 months ago

#10 @swissspidy
9 months ago

  • Milestone changed from 5.1 to 5.2

With 5.1 Beta 1 around the corner I guess we have to punt this.

This ticket was mentioned in Slack in #core-restapi by desrosj. View the logs.


9 months ago

#12 @kadamwhite
9 months ago

  • Owner set to kadamwhite
  • Status changed from assigned to accepted

#13 @swissspidy
9 months ago

#46138 was marked as a duplicate.

#14 @aduth
9 months ago

Related:

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


7 months ago

This ticket was mentioned in Slack in #core-restapi by kadamwhite. View the logs.


7 months ago

This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.


7 months ago

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


6 months ago

#19 @JeffPaul
6 months ago

  • Milestone changed from 5.2 to Future Release

Per input from @swissspidy and @kadamwhite in today's bugscrub, we're punting this as not enough time remains to get this into 5.2. Given the minimal movement during the 5.2 release cycle, I'm punting this to Future Release so that we consciously milestone this for a numbered release when we're ready to take it on.

Note: See TracTickets for help on using tickets.