WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#45450 closed defect (bug) (fixed)

Bundled themes: Default block appender markup now incorrect in editor-blocks.css

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch has-screenshots needs-testing commit fixed-5.0
Focuses: Cc:

Description (last modified by laurelfulford)

When using the new block editor, the placeholder blocks can be styled to match the theme's regular text, so they fit into the design. This was done with the default themes.

To fix another issue, the markup for this placeholder element was recently changed, switching it from an input to a textarea. This means the CSS selector for this element in each theme also needs to be updated.

(Thanks to @joen for pointing out this issue in #45421!)

Attachments (17)

twenty-seventeen-block-appender-before.png (14.0 KB) - added by laurelfulford 3 years ago.
Twenty Seventeen - block appender before
twenty-sixteen-block-appender-before.png (15.2 KB) - added by laurelfulford 3 years ago.
Twenty Sixteen - block appender before
twenty-fifteen-block-appender-before.png (15.4 KB) - added by laurelfulford 3 years ago.
Twenty Fifteen - block appender before
twenty-fourteen-block-appender-before.png (12.0 KB) - added by laurelfulford 3 years ago.
Twenty Fourteen - block appender before
twenty-thirteen-block-appender-before.png (15.4 KB) - added by laurelfulford 3 years ago.
Twenty Thirteen - block appender before
twenty-twelve-block-appender-before.png (12.9 KB) - added by laurelfulford 3 years ago.
Twenty Twelve - block appender before
twenty-eleven-block-appender-before.png (13.2 KB) - added by laurelfulford 3 years ago.
Twenty Eleven - block appender before
twenty-ten-block-appender-before.png (12.8 KB) - added by laurelfulford 3 years ago.
Twenty Ten - block appender before
45450.patch (6.0 KB) - added by laurelfulford 3 years ago.
twenty-seventeen-block-appender-after.png (12.6 KB) - added by laurelfulford 3 years ago.
Twenty Seventeen - block appender after
twenty-sixteen-block-appender-after.png (15.4 KB) - added by laurelfulford 3 years ago.
Twenty Sixteen - block appender after
twenty-fifteen-block-appender-after.png (14.8 KB) - added by laurelfulford 3 years ago.
Twenty Fifteen - block appender after
twenty-fourteen-block-appender-after.png (11.2 KB) - added by laurelfulford 3 years ago.
Twenty Fourteen - block appender after
twenty-thirteen-block-appender-after.png (14.8 KB) - added by laurelfulford 3 years ago.
Twenty Thirteen - block appender after
twenty-twelve-block-appender-after.png (11.8 KB) - added by laurelfulford 3 years ago.
Twenty Twelve - block appender after
twenty-eleven-block-appender-after.png (12.3 KB) - added by laurelfulford 3 years ago.
Twenty Eleven - block appender after
twenty-ten-block-appender-after.png (12.8 KB) - added by laurelfulford 3 years ago.
Twenty Ten - block appender after

Download all attachments as: .zip

Change History (26)

@laurelfulford
3 years ago

Twenty Seventeen - block appender before

@laurelfulford
3 years ago

Twenty Sixteen - block appender before

@laurelfulford
3 years ago

Twenty Fifteen - block appender before

@laurelfulford
3 years ago

Twenty Fourteen - block appender before

@laurelfulford
3 years ago

Twenty Thirteen - block appender before

@laurelfulford
3 years ago

Twenty Twelve - block appender before

@laurelfulford
3 years ago

Twenty Eleven - block appender before

@laurelfulford
3 years ago

Twenty Ten - block appender before

@laurelfulford
3 years ago

@laurelfulford
3 years ago

Twenty Seventeen - block appender after

@laurelfulford
3 years ago

Twenty Sixteen - block appender after

@laurelfulford
3 years ago

Twenty Fifteen - block appender after

@laurelfulford
3 years ago

Twenty Fourteen - block appender after

@laurelfulford
3 years ago

Twenty Thirteen - block appender after

@laurelfulford
3 years ago

Twenty Twelve - block appender after

@laurelfulford
3 years ago

Twenty Eleven - block appender after

@laurelfulford
3 years ago

Twenty Ten - block appender after

#1 @laurelfulford
3 years ago

45450.patch makes sure the text "Start writing or type / to choose a block" uses the same font face and size as each theme's actual text styles.

#2 @laurelfulford
3 years ago

  • Description modified (diff)

#3 @Joen
3 years ago

This is wonderful, thank you! All patches look good 👍 👍

#4 @laurelfulford
3 years ago

  • Milestone changed from Awaiting Review to 5.0.1

#5 @pento
3 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @desrosj
3 years ago

  • Keywords commit added

Looks good, @laurelfulford!

#7 @laurelfulford
3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44212:

Bundled Themes: Update default block appender selector.

The markup for the default block appender changed from a text input to a text area in the editor; this update makes the same change in the default theme styles.

Fixes #45450.

#8 @SergeyBiryukov
3 years ago

  • Keywords fixed-5.0 added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for trunk.

#9 @desrosj
3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44312:

Bundled Themes: Update default block appender selector.

The markup for the default block appender changed from a text input to a text area in the editor; this update makes the same change in the default theme styles.

Props laurelfulford.

Merges [44212] into trunk.

Fixes #45450.

Note: See TracTickets for help on using tickets.