WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 8 months ago

#45452 closed defect (bug) (fixed)

Bundled Themes: De-Gutenbergify comments and CSS selectors

Reported by: laurelfulford Owned by: laurelfulford
Milestone: 5.0.2 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch commit fixed-5.0
Focuses: Cc:

Description

In the existing default themes, the term "Gutenberg" should be replaced in the block stylesheets with something more future-friendly, like "block-based editor".

In all of the themes, 'Gutenberg' is mentioned at the top of the blocks.css and editor-blocks.css files in a CSS comment, and above the block-based editor CSS enqueue in the functions.php in a PHP comment.

Twenty Seventeen uses the class .gutenberg-editor-page in the editor-blocks.css, in the style:

/* Background color */

.gutenberg-editor-page .editor-block-list__block {
	background-color: transparent;
}

Looking at the editor, it looks like the issue this style was meant to fix is no longer present; when the style is removed, the .editor-block-list__block still doesn't have any background colour. So I think this one is safe to remove outright.

Twenty Twelve uses the class .gutenberg in the editor-blocks.css for the widget block styles. These styles are still needed, but this class can be replaced with .editor-block-list__block.

Attachments (1)

45452.patch (12.2 KB) - added by laurelfulford 9 months ago.

Download all attachments as: .zip

Change History (7)

#1 @pento
8 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#2 @desrosj
8 months ago

  • Keywords commit added; needs-testing removed

Works great, and patch looks good, @laurelfulford! Verified the two scenarios you discussed in the description.

Last edited 8 months ago by desrosj (previous) (diff)

#3 @laurelfulford
8 months ago

Awesome - thanks for verifying, @desrosj!

#4 @laurelfulford
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44213:

Bundled Themes: Replace “Gutenberg” in code comments and classes.

This update replaces the term “Gutenberg” in the themes code comments and classes with something more future-friendly.

Fixes #45452.

#5 @SergeyBiryukov
8 months ago

  • Keywords fixed-5.0 added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for trunk.

#6 @desrosj
8 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44313:

Bundled Themes: Replace “Gutenberg” in code comments and classes.

This update replaces the term “Gutenberg” in the themes code comments and classes with something more future-friendly.

Props laurelfulford.

Merges [44213] into trunk.

Fixes #45452.

Note: See TracTickets for help on using tickets.