#45453 closed defect (bug) (fixed)
Block Editor: Add a Message if JavaScript is disabled
Reported by: | mkaz | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.0.3 | Priority: | normal |
Severity: | normal | Version: | 5.0 |
Component: | Editor | Keywords: | has-patch has-screenshots |
Focuses: | Cc: |
Description
The editor shows a blank page if JavaScript is disabled.
It looks like PR 11642 from Gutenberg plugin didn't make it back to core.
https://github.com/WordPress/gutenberg/pull/11642
Attachments (9)
Change History (33)
#1
@
6 years ago
#2
@
6 years ago
- Component changed from General to Editor
- Keywords has-patch added
- Milestone changed from Awaiting Review to 5.0.1
- Version set to 5.0
#5
@
6 years ago
- Keywords dev-feedback added
- Milestone changed from 5.0.2 to 5.0.3
Thanks for the patch, @mkaz!
45453.2.diff makes some adjustments:
- Use the
hide-if-js
class instead of<noscript>
. - Simplify the inline CSS by hiding the
#editor
div. - Expand the message to recommend installing JavaScript.
- Apply a filter to the message, so the Classic Editor plugin can filter it appropriately.
I'm not wild about the inline CSS, but I'm also not aware of any existing class we could use the similar effect. Other screens that require JS (eg, the theme installer) display the <h1>
, so don't have this squished margin problem.
@azaozz: Will this filter do the job for the Classic Editor plugin to use?
#6
@
6 years ago
Will this filter do the job for the Classic Editor plugin to use?
Sure. Can replace the text and add a link to the user settings to set Classic as default.
Was wondering if we should also include the screen title there (will add a screenshot). Makes it a bit more friendlier.
While looking at that noticed some inconsistencies with the global $title
in edit-form-blocks.php
. It resets the $title to Edit Post at the top, then never uses it. Then uses $post_type_object->labels->edit_item
in the hidden a11y H1. Fixed that in 45453.3.diff to properly display either "Edit Post" or "Add New Post" but may be worth a new ticket.
In 45453.3.diff:
- Add the screen title when displaying the error message about no js.
- Fix the global
$title
and use it on theedit-form-blocks.php
.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
6 years ago
#8
@
6 years ago
- Keywords needs-refresh added
Patch is currently failing to apply to trunk
. I think it may have been written before 5.0 was merged.
#10
@
6 years ago
45453.5.diff updates Block Editor to be a proper noun for consistency. Also, I changed the notice classes to use the alternation styling, which is designed for use against white backgrounds. It provides better contrast and makes the notices stand out more.
#11
@
6 years ago
- Keywords needs-screenshots needs-refresh added; dev-feedback removed
"Block Editor" should be "block editor", without capitalizing the first letters. See also https://make.wordpress.org/core/handbook/best-practices/spelling/.
#12
@
6 years ago
Thanks @ocean90. I didn’t know about that page in the handbook. I had originally seen this in #45634. We’ll just have to clarify there that ‘block editor’ should be lowercase.
#13
@
6 years ago
- Keywords needs-refresh removed
45453.6.diff fixes the casing on "block editor". Also, attaching a screenshot of the alternate version in my patch.
#14
@
6 years ago
- Keywords commit has-screenshots added; needs-screenshots removed
/** Translators:
should be /* translators:
otherwise 45453.6.diff looks good.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
6 years ago
#17
@
6 years ago
45453.7.diff fixes the translator comment mentioned above, and also changes printf
to sprintf
. The trailing 182
in alternate-notice-style.png was the result of the string being output with printf
and the result (character count of the formatted string) being echoed below that.
#18
@
6 years ago
@desrosj I'm happy to confirm 45453.7.diff
applies well and fixes the string length output issue, thanks!
I'm added a patch which includes the code from the Gutenberg PR 11642
which displays a message and a link to the Classic Editor plugin if JavaScript is disabled.
The patch also includes the translation fix for the URL from Gutenberg PR 12013
Props to @dixitadusara and @swissspidy for that contribution.
https://github.com/WordPress/gutenberg/pull/12013