Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45456 closed defect (bug) (fixed)

PHP Notice: edit_form_advanced is deprecated since version 5.0.0!

Reported by: chouby's profile Chouby Owned by: desrosj's profile desrosj
Milestone: 5.0.2 Priority: normal
Severity: minor Version: 5.0
Component: Editor Keywords: has-patch fixed-5.0
Focuses: Cc:

Description

This notice is fired in the block editor due to:

add_action( 'edit_form_advanced', array( $this, 'maybe_run_ajax_cache' ) );

in class-wp-embed.php.

The issue has already been reported in #45341, but as this ticket doesn't focus on the notice but on different javascript errors, I thought it would be good to open a separate ticket.

Tested with 5.0-RC2-43958

Attachments (1)

45456.diff (1.8 KB) - added by pento 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @jorbin
6 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.0.1

I'm milestoning this to 5.0.1 due to the fact that the release is scheduled for tomorrow. If @pento wants to disagree and include it in 5.0.0, I wouldn't object.

#2 @ocean90
6 years ago

#45497 was marked as a duplicate.

This ticket was mentioned in Slack in #core by spacedmonkey. View the logs.


6 years ago

#4 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

@pento
6 years ago

#5 @pento
6 years ago

  • Keywords has-patch added; needs-patch removed

#6 @pento
6 years ago

In 44248:

Block Editor: Remove a deprecated notice being generated by the meta box compat functions.

See #45456.

#7 @pento
6 years ago

  • Keywords fixed-5.0 added

#8 @desrosj
6 years ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 44315:

Block Editor: Remove a deprecated notice being generated by the meta box compat functions.

Props pento.

Merges [44248] into trunk.

Fixes #45456.

Note: See TracTickets for help on using tickets.