WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#45460 closed enhancement (wontfix)

Escaping suggestion

Reported by: utsav72640's profile utsav72640 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch
Focuses: Cc:

Description

May be this escaping issue which is resolved by this patch.

Attachments (1)

escapingissue.patch​ (432 bytes) - added by utsav72640 5 years ago.

Download all attachments as: .zip

Change History (4)

@utsav72640
5 years ago

This ticket was mentioned in ​Slack in #core by utsav72640. ​View the logs.
5 years ago

#2 @swissspidy
5 years ago

  • Component changed from General to Users
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

The error messages are just translated strings coming from wpmu_activate_signup(). I don't think there's any point in escaping them as we trust translations coming from WordPress.org. Also, this would prevent anyone filtering the messages through gettext to include some HTML if they wanted to.

Two notes on your patch for future reference:

  • Please create patches from the base directory of your VCS checkout, so that it includes the full path to the file src/wp-activate.php and not just wp-activate.php
  • Please adhere to the ​WordPress coding standards and add spaces between parentheses.

#3 @SergeyBiryukov
5 years ago

  • Summary changed from Esacaping suggestion to Escaping suggestion
Note: See TracTickets for help on using tickets.