Context Navigation

← Previous Ticket
Next Ticket →

#45465 closed defect (bug) (fixed)

JavaScript translations are not loaded in the language of user locale

Reported by:	ReikoDD	Owned by:	desrosj
Priority:	normal	Milestone:	5.0
Component:	Editor	Version:	5.0
Severity:	normal	Keywords:	has-patch fixed-5.0
Cc:		Focuses:

Description (last modified by ocean90)

In RC2 the "German" Translation Strings are not correct. Its a mix of english an german.

Attachments (2)

Bildschirmfoto 2018-12-03 um 10.18.45.png (174.0 KB ) - added by ReikoDD 8 years ago.
45465.patch (517 bytes ) - added by ocean90 8 years ago.

Download all attachments as: .zip

Change History (10)

@ReikoDD
8 years ago

Attachment Bildschirmfoto 2018-12-03 um 10.18.45.png added

#1 @Presskopp
8 years ago

Component General → Editor

Thanks, @ReikoDD - let me add that this ticket has been created because several people are having the same scenario

#2 @ocean90
8 years ago

Description modified (diff)
Milestone Awaiting Review
Resolution → worksforme
Status new → closed

Thanks for the report. Please make sure you have the latest translations installed. You can check this on wp-admin/update-core.php or you can download the language pack from here. If you have Gutenberg activated try also to deactivate it.

#3 @Presskopp
8 years ago

I didn't have Gutenberg installed and I also have checked for updates. After downloading the language pack I still see the mixture.

#4 @ocean90
8 years ago

Keywords needs-patch added
Milestone → 5.0
Resolution worksforme
Status closed → reopened
Summary German Strings a mix of English and German → JavaScript translations are not loaded in the language of user locale

@ocean90
8 years ago

Attachment 45465.patch added

#5 @ocean90
8 years ago

Keywords has-patch added; needs-patch removed

45465.patch : The check for the current locale was reversed, fixed by replacing the check with determine_locale() introduced in [43776].

#6 @pento
8 years ago

In 43959:

l10n: Ensure JavaScript language packages are loaded for the user locale.

load_script_textdomain() had a reversed check to decide if the user locale should be loaded. This check is now replaced with determine_local().

Props ocean90.
See #45465.

#7 @pento
8 years ago

Keywords fixed-5.0 added

#8 @desrosj
8 years ago

Owner set to desrosj
Resolution → fixed
Status reopened → closed

In 44278:

l10n: Ensure JavaScript language packages are loaded for the user locale.

load_script_textdomain() had a reversed check to decide if the user locale should be loaded. This check is now replaced with determine_local().

Props ocean90.

Merges [43959] into trunk.

Fixes #45465.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#45465 closed defect (bug) (fixed)

JavaScript translations are not loaded in the language of user locale

Description (last modified by ocean90)

Attachments (2)

Change History (10)

@ReikoDD 8 years ago

#1 @Presskopp 8 years ago

#2 @ocean90 8 years ago

#3 @Presskopp 8 years ago

#4 @ocean90 8 years ago

@ocean90 8 years ago

#5 @ocean90 8 years ago

#6 @pento 8 years ago

#7 @pento 8 years ago

#8 @desrosj 8 years ago