WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 9 months ago

#45465 closed defect (bug) (fixed)

JavaScript translations are not loaded in the language of user locale

Reported by: ReikoDD Owned by: desrosj
Milestone: 5.0 Priority: normal
Severity: normal Version: 5.0
Component: Editor Keywords: has-patch fixed-5.0
Focuses: Cc:

Description (last modified by ocean90)

In RC2 the "German" Translation Strings are not correct. Its a mix of english an german.

Attachments (2)

Bildschirmfoto 2018-12-03 um 10.18.45.png (174.0 KB) - added by ReikoDD 10 months ago.
45465.patch (517 bytes) - added by ocean90 10 months ago.

Download all attachments as: .zip

Change History (10)

#1 @Presskopp
10 months ago

  • Component changed from General to Editor

Thanks, @ReikoDD - let me add that this ticket has been created because several people are having the same scenario

#2 @ocean90
10 months ago

  • Description modified (diff)
  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Thanks for the report. Please make sure you have the latest translations installed. You can check this on wp-admin/update-core.php or you can download the language pack from here. If you have Gutenberg activated try also to deactivate it.

#3 @Presskopp
10 months ago

I didn't have Gutenberg installed and I also have checked for updates. After downloading the language pack I still see the mixture.

#4 @ocean90
10 months ago

  • Keywords needs-patch added
  • Milestone set to 5.0
  • Resolution worksforme deleted
  • Status changed from closed to reopened
  • Summary changed from German Strings a mix of English and German to JavaScript translations are not loaded in the language of user locale

@ocean90
10 months ago

#5 @ocean90
10 months ago

  • Keywords has-patch added; needs-patch removed

45465.patch: The check for the current locale was reversed, fixed by replacing the check with determine_locale() introduced in [43776].

#6 @pento
10 months ago

In 43959:

l10n: Ensure JavaScript language packages are loaded for the user locale.

load_script_textdomain() had a reversed check to decide if the user locale should be loaded. This check is now replaced with determine_local().

Props ocean90.
See #45465.

#7 @pento
10 months ago

  • Keywords fixed-5.0 added

#8 @desrosj
9 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from reopened to closed

In 44278:

l10n: Ensure JavaScript language packages are loaded for the user locale.

load_script_textdomain() had a reversed check to decide if the user locale should be loaded. This check is now replaced with determine_local().

Props ocean90.

Merges [43959] into trunk.

Fixes #45465.

Note: See TracTickets for help on using tickets.