WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 2 years ago

#45473 new defect (bug)

Twenty Nineteen: Avoid html code in translatable strings

Reported by: Presskopp Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

As always only the translatable part should appear for translators to avoid issues.

I came across this one:

<span class="meta-nav">Published in</span><br><span class="post-title">%title</span>

Attachments (1)

45473.patch (1.4 KB) - added by mukesh27 2 years ago.
Patch.

Download all attachments as: .zip

Change History (14)

#1 @SergeyBiryukov
2 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.0.1

#3 @pento
2 years ago

  • Milestone changed from 5.0.1 to 5.0.2

@mukesh27
2 years ago

Patch.

#4 @mukesh27
2 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


2 years ago

#6 @pento
2 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#7 @laurelfulford
2 years ago

  • Keywords 2nd-opinion added

Thanks for the report, @Presskopp!

It looks like there's been quite a bit of discussion about the best approach for this issue, shared in Twenty Nineteen GitHub repo, on top of https://github.com/WordPress/twentynineteen/issues/725 shared above:

@kjellr or @allancole -- I'm definitely not up to date where this ended up in Twenty Nineteen. Is there a particular direction that was decided on for HTML in strings marked for translation? From my read it sounds like it may make sense to keep the HTML in some cases, but I could be wrong!

#8 @laurelfulford
2 years ago

  • Milestone changed from 5.0.3 to 5.1

It seems like this one could be a bit too involved for 5.0.3, so punting to 5.1.

#9 @kjellr
2 years ago

From my read it sounds like it may make sense to keep the HTML in some cases, but I could be wrong!

That's my understanding here too, but I'd defer to the i18n experts.

Regarding @mukesh27's patch above, @grapplerulrich noted that this may not work because some languages may need to have this string rearranged to say "Title published in".

Last edited 2 years ago by kjellr (previous) (diff)

#10 @laurelfulford
2 years ago

  • Milestone changed from 5.1 to 5.2

Punting this issue for now, as we figure out exactly what strings need to be updated.

#11 @SergeyBiryukov
2 years ago

Just noting the string in question is not much different from similar "Published in" strings in Twenty Fourteen, Fifteen, and Sixteen, so the issue is not unique to Twenty Nineteen.

#12 @desrosj
2 years ago

This still needs work and has not been touched since being punted to 5.2. Moving to Future Release until someone is able to work on this.

#13 @desrosj
2 years ago

  • Milestone changed from 5.2 to Future Release
Note: See TracTickets for help on using tickets.