Opened 2 years ago
Last modified 2 years ago
#45473 new defect (bug)
Twenty Nineteen: Avoid html code in translatable strings
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch 2nd-opinion |
Focuses: | Cc: |
Description
As always only the translatable part should appear for translators to avoid issues.
I came across this one:
<span class="meta-nav">Published in</span><br><span class="post-title">%title</span>
Attachments (1)
Change History (14)
This ticket was mentioned in Slack in #core-themes by kjell. View the logs.
2 years ago
#7
@
2 years ago
- Keywords 2nd-opinion added
Thanks for the report, @Presskopp!
It looks like there's been quite a bit of discussion about the best approach for this issue, shared in Twenty Nineteen GitHub repo, on top of https://github.com/WordPress/twentynineteen/issues/725 shared above:
- https://github.com/WordPress/twentynineteen/pull/274 (looks like the bulk of the conversation happens here)
- https://github.com/WordPress/twentynineteen/pull/733
- https://github.com/WordPress/twentynineteen/pull/734
@kjellr or @allancole -- I'm definitely not up to date where this ended up in Twenty Nineteen. Is there a particular direction that was decided on for HTML in strings marked for translation? From my read it sounds like it may make sense to keep the HTML in some cases, but I could be wrong!
#8
@
2 years ago
- Milestone changed from 5.0.3 to 5.1
It seems like this one could be a bit too involved for 5.0.3, so punting to 5.1.
#9
@
2 years ago
From my read it sounds like it may make sense to keep the HTML in some cases, but I could be wrong!
That's my understanding here too, but I'd defer to the i18n experts.
Regarding @mukesh27's patch above, @grapplerulrich noted that this may not work because some languages may need to have this string rearranged to say "Title published in".
#10
@
2 years ago
- Milestone changed from 5.1 to 5.2
Punting this issue for now, as we figure out exactly what strings need to be updated.
#11
@
2 years ago
Just noting the string in question is not much different from similar "Published in" strings in Twenty Fourteen, Fifteen, and Sixteen, so the issue is not unique to Twenty Nineteen.
Github 725