Make WordPress Core

Opened 5 years ago

Last modified 10 months ago

#45473 new defect (bug)

Twenty Nineteen: Avoid html code in translatable strings

Reported by: presskopp's profile Presskopp Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

As always only the translatable part should appear for translators to avoid issues.

I came across this one:

<span class="meta-nav">Published in</span><br><span class="post-title">%title</span>

Attachments (6)

45473.patch (1.4 KB) - added by mukesh27 5 years ago.
Patch.
2019-JPEG-published-in.png (7.6 KB) - added by sabernhardt 10 months ago.
Twenty Nineteen: image attachment template gives a line break before post title
2019-PDF-published-in.png (7.5 KB) - added by sabernhardt 10 months ago.
Twenty Nineteen: non-image attachment page has no line break (and no space either) before post title
2021-JPEG-published-in.png (227.3 KB) - added by sabernhardt 10 months ago.
Twenty Twenty-One: image attachment template only links the post title, with the parent post text in the article's footer
2021-PDF-published-in.png (12.1 KB) - added by sabernhardt 10 months ago.
Twenty Twenty-One: non-image attachment page uses styling similar to the previous post link but without the SVG
45473.1.patch (768 bytes) - added by sabernhardt 10 months ago.
use the string with the line break for all attachment pages in Twenty Nineteen

Download all attachments as: .zip

Change History (20)

#1 @SergeyBiryukov
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.0.1

#3 @pento
5 years ago

  • Milestone changed from 5.0.1 to 5.0.2

@mukesh27
5 years ago

Patch.

#4 @mukesh27
5 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


5 years ago

#6 @pento
5 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#7 @laurelfulford
5 years ago

  • Keywords 2nd-opinion added

Thanks for the report, @Presskopp!

It looks like there's been quite a bit of discussion about the best approach for this issue, shared in Twenty Nineteen GitHub repo, on top of https://github.com/WordPress/twentynineteen/issues/725 shared above:

@kjellr or @allancole -- I'm definitely not up to date where this ended up in Twenty Nineteen. Is there a particular direction that was decided on for HTML in strings marked for translation? From my read it sounds like it may make sense to keep the HTML in some cases, but I could be wrong!

#8 @laurelfulford
5 years ago

  • Milestone changed from 5.0.3 to 5.1

It seems like this one could be a bit too involved for 5.0.3, so punting to 5.1.

#9 @kjellr
5 years ago

From my read it sounds like it may make sense to keep the HTML in some cases, but I could be wrong!

That's my understanding here too, but I'd defer to the i18n experts.

Regarding @mukesh27's patch above, @grapplerulrich noted that this may not work because some languages may need to have this string rearranged to say "Title published in".

Last edited 5 years ago by kjellr (previous) (diff)

#10 @laurelfulford
5 years ago

  • Milestone changed from 5.1 to 5.2

Punting this issue for now, as we figure out exactly what strings need to be updated.

#11 @SergeyBiryukov
5 years ago

Just noting the string in question is not much different from similar "Published in" strings in Twenty Fourteen, Fifteen, and Sixteen, so the issue is not unique to Twenty Nineteen.

#12 @desrosj
5 years ago

This still needs work and has not been touched since being punted to 5.2. Moving to Future Release until someone is able to work on this.

#13 @desrosj
5 years ago

  • Milestone changed from 5.2 to Future Release

@sabernhardt
10 months ago

Twenty Nineteen: image attachment template gives a line break before post title

@sabernhardt
10 months ago

Twenty Nineteen: non-image attachment page has no line break (and no space either) before post title

@sabernhardt
10 months ago

Twenty Twenty-One: image attachment template only links the post title, with the parent post text in the article's footer

@sabernhardt
10 months ago

Twenty Twenty-One: non-image attachment page uses styling similar to the previous post link but without the SVG

@sabernhardt
10 months ago

use the string with the line break for all attachment pages in Twenty Nineteen

#14 @sabernhardt
10 months ago

HTML in a string is sometimes necessary for more accurate translations; [55655] specifically created two of them. Some languages add the title before "Published in" in at least one of the bundled themes. And Kurdish (Kurmanji) includes text outside of either span tag:
<span class="meta-nav">Di nav</span><br><span class="post-title">%title</span> de hate weşandin

However, I do not like having two different translations for the parent post link, depending on whether the attachment is an image or another type. Both Twenty Nineteen and Twenty Twenty-One have multiple translations, and the styling breaks, too. 45473.1.patch reuses the same string for non-image attachments in Twenty Nineteen, adding the br tag.

Using 'Published in %s' for non-image attachment pages in Twenty Twenty-One might require editing both the single.php template and twenty_twenty_one_entry_meta_footer(). That could be addressed on another ticket.

I do not find much value in changing the other three themes now. Twenty Fourteen is also inconsistent for different attachment types, though without broken styling. Twenty Fifteen and Twenty Sixteen have consistent links for any attachment type, and the strings are even identical between both of those themes.

Note: See TracTickets for help on using tickets.