Twenty Nineteen: edit translatable strings with HTML code

[Presskopp]

As always only the translatable part should appear for translators to avoid issues.

I came across this one:

<span class="meta-nav">Published in</span><br><span class="post-title">%title</span>

[pratikkry]

Github ​725

[mukesh27]

Patch.

[laurelfulford]

Thanks for the report, @Presskopp!

It looks like there's been quite a bit of discussion about the best approach for this issue, shared in Twenty Nineteen GitHub repo, on top of ​https://github.com/WordPress/twentynineteen/issues/725 shared above:

• ​https://github.com/WordPress/twentynineteen/pull/274 (looks like the bulk of the conversation happens here)
• ​https://github.com/WordPress/twentynineteen/pull/733
• ​https://github.com/WordPress/twentynineteen/pull/734

@kjellr or @allancole -- I'm definitely not up to date where this ended up in Twenty Nineteen. Is there a particular direction that was decided on for HTML in strings marked for translation? From my read it sounds like it may make sense to keep the HTML in some cases, but I could be wrong!

[laurelfulford]

It seems like this one could be a bit too involved for 5.0.3, so punting to 5.1.

[kjellr]

From my read it sounds like it may make sense to keep the HTML in some cases, but I could be wrong!

That's my understanding here too, but I'd defer to the i11n experts.

Regarding @mukesh27's patch above, @grapplerulrich noted that this may not work because some languages may need to have this string rearranged to say "Title published in".

[laurelfulford]

Punting this issue for now, as we figure out exactly what strings need to be updated.

[SergeyBiryukov]

Just noting the string in question is not much different from similar "Published in" strings in Twenty Fourteen, Fifteen, and Sixteen, so the issue is not unique to Twenty Nineteen.

[desrosj]

This still needs work and has not been touched since being punted to 5.2. Moving to Future Release until someone is able to work on this.

[sabernhardt]

Twenty Nineteen: image attachment template gives a line break before post title

[sabernhardt]

Twenty Nineteen: non-image attachment page has no line break (and no space either) before post title

[sabernhardt]

Twenty Twenty-One: image attachment template only links the post title, with the parent post text in the article's footer

[sabernhardt]

Twenty Twenty-One: non-image attachment page uses styling similar to the previous post link but without the SVG

[sabernhardt]

use the string with the line break for all attachment pages in Twenty Nineteen

[sabernhardt]

HTML in a string is sometimes necessary for more accurate translations; [55655] specifically created two of them. Some languages ​add the title before "Published in" in at least one of the bundled themes. And Kurdish (Kurmanji) includes text outside of either span tag:
<span class="meta-nav">Di nav</span><br><span class="post-title">%title</span> de hate weşandin

However, I do not like having two different translations for the parent post link, depending on whether the attachment is an image or another type. Both Twenty Nineteen and Twenty Twenty-One have multiple translations, and the styling breaks, too. 45473.1.patch​ reuses the same string for non-image attachments in Twenty Nineteen, adding the br tag.

Using 'Published in %s' for non-image attachment pages in Twenty Twenty-One might require editing both the single.php template and twenty_twenty_one_entry_meta_footer(). That could be addressed on another ticket.

I do not find much value in changing the other three themes now. Twenty Fourteen is also inconsistent for different attachment types, though without broken styling. Twenty Fifteen and Twenty Sixteen have consistent links for any attachment type, and the strings are even identical between both of those themes.

[karmatosed]

@sabernhardt I wanted to check if you felt there was still value in changing this now?

[sabernhardt]

refreshed

[sabernhardt]

I think it is still worth making Twenty Nineteen's "Published in" links consistent for any attachment page (but probably no other changes this late). The patch only replaces one string with another that already exists.

The %s might have been a better placeholder than %title if it had been used in both templates, yet more languages have translations for the %title string. Also, the theme's design added a line break in those links, and the %title string has that.

I edited the ticket summary because the patch does not follow the original direction. 45473.1.patch applied for me, but I refreshed it anyway.

[sabernhardt]

Twenty Nineteen parent post links before patch: video attachment page does not have a line break (or space) before title

[sabernhardt]

Twenty Nineteen parent post links with 45473.patch: video and image attachment pages have line break before title, in both English and French

[karmatosed]

I can confirm that the latest patch works and I agree with the approach in it. As a result, I am going to push this to commit so we can get progress on this ticket. Thanks everyone.

[karmatosed]

In 58881:

Twenty Nineteen: Fixes translatable strings with HTML code not appearing.

Only the translatable part not HTML, should appear for translators to avoid issues. This resolves one string that was not appearing. This only fixed for one theme although discussion on the ticket was for multiples. Other tickets should be open for those if desireable.

Props Presskopp, SergeyBiryukov, pratikkry, pento, mukesh27, laurelfulford, kjellr, desrosj, sabernhardt.
Fixes #45473.