WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45489 closed enhancement (fixed)

Make domain argument optional in wp_set_script_translations() / WP_Scripts::set_translations()

Reported by: swissspidy's profile swissspidy Owned by: swissspidy's profile swissspidy
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.0
Component: I18N Keywords: has-patch commit
Focuses: Cc:

Description

The $domain should default to default, just like it does in all the other l10n functions we have in core.

Attachments (2)

45489.diff​ (4.2 KB) - added by swissspidy 6 years ago.
45489.2.diff​ (4.7 KB) - added by swissspidy 6 years ago.

Download all attachments as: .zip

Change History (11)

@swissspidy
6 years ago

#1 @swissspidy
6 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

#2 @ocean90
6 years ago

  • Keywords commit added; dev-feedback removed

👍

#3 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#4 @swissspidy
6 years ago

  • Version set to 5.0

#5 @pento
6 years ago

  • Keywords needs-refresh added; commit removed
  • Milestone changed from 5.0.2 to 5.0.3

#6 @audrasjb
6 years ago

Hi,

5.0.3 is going to be released in a couple of weeks. We are currently sorting the remaining tickets in the milestone. The ticket is sorted in milestone 5.0.3, but requires an @since refresh and a commit/backport to the associated branch. That would be great to have a refreshed patch asap.

@swissspidy
6 years ago

#7 @swissspidy
6 years ago

  • Keywords commit added; needs-refresh removed

#8 @ocean90
6 years ago

  • Milestone changed from 5.0.3 to 5.1

Having this only in the next major release should be good enough.

#9 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44395:

I18N: Make domain argument optional in wp_set_script_translations() / WP_Scripts::set_translations().

Props swissspidy.
Fixes #45489.

Note: See TracTickets for help on using tickets.