WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#45506 closed defect (bug) (fixed)

wp_register_tinymce_scripts() provides incorrect arguments to includes_url()

Reported by: volodymyrkolesnykov Owned by: desrosj
Priority: normal Milestone: 5.0.2
Component: Script Loader Version: 5.0
Severity: normal Keywords: fixed-5.0 has-patch
Cc: Focuses:

Description 

$scripts->add( 'wp-tinymce-lists', includes_url( "js/tinymce/plugins/lists/plugin$suffix.js", array( 'wp-tinymce' ), $tinymce_version ) );

should be

$scripts->add( 'wp-tinymce-lists', includes_url( "js/tinymce/plugins/lists/plugin$suffix.js" ), array( 'wp-tinymce' ), $tinymce_version );

Right now, array( 'wp-tinymce' ) is passed as $scheme argument to includes_url(), and according to the documentation, it should be either string or null, not an array.

Attachments (1)

45506.patch​ (614 bytes ) - added by volodymyrkolesnykov 8 years ago.
Patch

Download all attachments as: .zip

Change History (9)

@volodymyrkolesnykov
8 years ago

Patch

#1 @volodymyrkolesnykov
8 years ago

  • Component General → Script Loader
  • Keywords has-patch added

#2 @SergeyBiryukov
8 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 5.0.1

#3 @SergeyBiryukov
8 years ago

Hi @volodymyrkolesnykov, welcome to WordPress Trac!

Good catch, thanks for the report!

#4 @pento
8 years ago

  • Milestone 5.0.1 → 5.0.2

#5 @desrosj
8 years ago

  • Owner set to desrosj
  • Status new → assigned

#6 @desrosj
8 years ago

  • Resolution → fixed
  • Status assigned → closed

In 44211:

Script Loader: Misplaced parenthesis when wp-tinymce-lists is added.

A closing parenthesis was misplaced in the $scripts->add( 'wp-tinymce-lists' ) call, causing the dependencies and version to be incorrectly passed to includes_url() instead.

Props volodymyrkolesnykov.
Fixes: #45506.

#7 @desrosj
8 years ago

  • Keywords fixed-5.0 added; commit removed
  • Resolution fixed
  • Status closed → reopened

Reopening for merge into trunk.

#8 @desrosj
8 years ago

  • Resolution → fixed
  • Status reopened → closed

In 44308:

Script Loader: Misplaced parenthesis when wp-tinymce-lists is added.

A closing parenthesis was misplaced in the $scripts->add( 'wp-tinymce-lists' ) call, causing the dependencies and version to be incorrectly passed to includes_url() instead.

Also, Remove an incorrect parameter sent to wp_get_script_polyfill(). wp_get_script_polyfill() only accepts two parameters, but this call was passing a third.

Props volodymyrkolesnykov, swissspidy.

Merges [44208] and [44211] into trunk.

Fixes: #45506, #45472.

Note: See TracTickets for help on using tickets.