Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#45517 closed defect (bug) (invalid)

Gist embeds no longer work with 5.0

Reported by: dartiss's profile dartiss Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.0
Component: Embeds Keywords:
Focuses: Cc:

Description

This was reported by a forum user (https://wordpress.org/support/topic/unable-to-embed-github-gist/), by I can recreate the issue myself (and will affect me in due course).

When running WordPress 4.9.8 with Gutenberg you could embed Gists - indeed, I have a number of such embeds on my site. However, update to WordPress 5.0 and the Gists stop working. Within the editor it says "Sorry, we could not embed that content.". If you then attempt to display this, it just shows the URL.

On my 5.0 test site I had an older post with a Gist in it (and one that worked before) and this just displays the URL now (and unlinked) - this therefore looks to me as if previous Gist embeds will now stop working once updated to 5.0.

Change History (4)

#1 @Otto42
6 years ago

Can you show the difference between 4.9.8 and 5.0?

WordPress does not have any specific support for github gist embeds as far as I can tell, and since the gists I'm looking at don't have oembed headers, then as far as I know, they don't automatically embed on either version.

You can use their embed code, certainly. But in both 4.9.8 and 5.0, since gist has no oembed headers, then just pasting the link on it's own line will not work for Gists. You have to copy their HTML.

Last edited 6 years ago by Otto42 (previous) (diff)

#2 @dartiss
6 years ago

You're right @Otto42 (of course you are!). I think this is Jetpack - I think Jetpack supported Gist embeds and now, for whatever reason, don't.

I'll take the discussion there. Thanks.

#3 @Otto42
6 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

#4 @SergeyBiryukov
6 years ago

  • Component changed from General to Embeds
Note: See TracTickets for help on using tickets.